Bug 132917 – remove duplicate code in web timing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alex Christensen]

I added some duplicate code copying timing data from the NSURLConnection to the ResourceLoadTiming in https://bugs.webkit.org/show_bug.cgi?id=132574 and I'm going to move that code to ResourceHandle.

[Alex Christensen]

Created attachment 231459 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 231459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231459&action=review

> Source/WebCore/platform/network/ResourceHandle.h:33
> +#include "ResourceLoadTiming.h"

Please don't include it, just forward declare.

> Source/WebCore/platform/network/ResourceHandle.h:134
> +    static void transferTimingData(NSURLConnection*, ResourceLoadTiming&);

I'd say "get", not "transfer".

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:175
> +    ResourceHandle::transferTimingData(connection, resourceResponse.resourceLoadTiming());

This is not what I was thinking of - I think that a nicer way to implement this would be to call into ResourceHandle here, which would then read the timing data, and call the client. Duplicating even the ResourceHandle::transferTimingData still leaves the potential for us to forget about it in future reimplementations.

It's OK to land as is though, the patch is an improvement.

[Alex Christensen]

(In reply to comment #2)
> Please don't include it, just forward declare.
done
> I'd say "get", not "transfer".
done

Committed with these changes to http://trac.webkit.org/changeset/168849