I added some duplicate code copying timing data from the NSURLConnection to the ResourceLoadTiming in https://bugs.webkit.org/show_bug.cgi?id=132574 and I'm going to move that code to ResourceHandle.
Created attachment 231459 [details]
Comment on attachment 231459 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=231459&action=review
> +#include "ResourceLoadTiming.h"
Please don't include it, just forward declare.
> + static void transferTimingData(NSURLConnection*, ResourceLoadTiming&);
I'd say "get", not "transfer".
> + ResourceHandle::transferTimingData(connection, resourceResponse.resourceLoadTiming());
This is not what I was thinking of - I think that a nicer way to implement this would be to call into ResourceHandle here, which would then read the timing data, and call the client. Duplicating even the ResourceHandle::transferTimingData still leaves the potential for us to forget about it in future reimplementations.
It's OK to land as is though, the patch is an improvement.
(In reply to comment #2)
> Please don't include it, just forward declare.
> I'd say "get", not "transfer".
Committed with these changes to http://trac.webkit.org/changeset/168849