Bug 132702 - [GStreamer] Some cosmetic changes to the backend
Summary: [GStreamer] Some cosmetic changes to the backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-08 13:19 PDT by Xabier Rodríguez Calvar
Modified: 2014-05-13 08:20 PDT (History)
13 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2014-05-08 13:22 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (4.91 KB, patch)
2014-05-09 04:24 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2014-05-08 13:19:39 PDT 
[GStreamer] Move toGstClockTime to utilities
Comment 1 Xabier Rodríguez Calvar 2014-05-08 13:22:23 PDT 
Created attachment 231097 [details]
Patch
Comment 2 Martin Robinson 2014-05-08 13:23:02 PDT 
Comment on attachment 231097 [details]
Patch

Is this used in any other file?
Comment 3 Xabier Rodríguez Calvar 2014-05-08 15:42:24 PDT 
(In reply to comment #2)
> (From update of attachment 231097 [details])
> Is this used in any other file?

No.
Comment 4 Martin Robinson 2014-05-08 16:37:32 PDT 
I think we only move code to utility files if it's shared between multiple code units.
Comment 5 Xabier Rodríguez Calvar 2014-05-08 16:47:15 PDT 
(In reply to comment #4)
> I think we only move code to utility files if it's shared between multiple code units.

We have GStreamer utilities in that file that are used only in one file. Actually in some patch I was asked to move utility functions to that file. That's the reason why I thought it was better to move it.
Comment 6 Xabier Rodríguez Calvar 2014-05-09 04:24:47 PDT 
Created attachment 231141 [details]
Patch
Comment 7 Xabier Rodríguez Calvar 2014-05-13 02:36:53 PDT 
Any more comments/review here?
Comment 8 WebKit Commit Bot 2014-05-13 08:20:48 PDT 
Comment on attachment 231141 [details]
Patch

Clearing flags on attachment: 231141

Committed r168681: <http://trac.webkit.org/changeset/168681>
Comment 9 WebKit Commit Bot 2014-05-13 08:20:53 PDT 
All reviewed patches have been landed.  Closing bug.