RESOLVED FIXED132596
REGRESSION(r155957): Selection rects are incorrect when the selection contains BR elements. 
https://bugs.webkit.org/show_bug.cgi?id=132596
Summary REGRESSION(r155957): Selection rects are incorrect when the selection contain...
Enrica Casucci
Reported 2014-05-05 18:19:06 PDT
This was introduced by http://trac.webkit.org/changeset/155957 The renderer for BR elements used to inherit from RenderText before the change listed above. RenderText has an implementation of the method collectSelectionRects, available only for iOS. RenderLineBreak doesn't have one and it defaults to the implementation in RenderObject that doesn't return the correct rectangle and most of all does not provide the correct annotations for the rect. The above mentioned change also changes the behavior of the renderer when it is not the only element on the line, which creates additional problems. Among the various reported issues are: - the selection is not drawn when BR is the only element on the line - overlapping selections when two lines of text are separated by BR. <rdar://problem/16464668> <rdar://problem/16692206> <rdar://problem/16776004>
Attachments
Patch (5.21 KB, patch)
2014-05-05 18:22 PDT, Enrica Casucci 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2014-05-05 18:22:54 PDT
Created attachment 230878 [details] Patch
Antti Koivisto
Comment 2 2014-05-06 00:05:53 PDT
We should really move this stuff out from PLATFORM(IOS) and make it testable with an internal setting.
Enrica Casucci
Comment 3 2014-05-06 10:50:46 PDT
Committed revision 168364.
Note You need to log in before you can comment on or make changes to this bug.