Bug 132494 - Implement FormData decoding using KeyedDecoder
Summary: Implement FormData decoding using KeyedDecoder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-02 15:07 PDT by Anders Carlsson
Modified: 2014-05-02 15:39 PDT (History)
0 users

See Also:


Attachments
Patch (5.20 KB, patch)
2014-05-02 15:09 PDT, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-05-02 15:07:45 PDT
Implement FormData decoding using KeyedDecoder
Comment 1 Anders Carlsson 2014-05-02 15:09:44 PDT
Created attachment 230706 [details]
Patch
Comment 2 Tim Horton 2014-05-02 15:22:48 PDT
Comment on attachment 230706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230706&action=review

> Source/WebCore/platform/network/FormData.cpp:679
> +    if (!decoder.decodeObjects("elements", data->m_elements, [](KeyedDecoder& decoder, FormDataElement& element) {
> +        return decodeElement(decoder, element);
> +    }))
> +        return nullptr;

I will note that this looks pretty bizarre.
Comment 3 Anders Carlsson 2014-05-02 15:39:12 PDT
Committed r168199: <http://trac.webkit.org/changeset/168199>