Bug 132409 - Web Inspector: Allow Remote Inspector to entitlement check UIProcess through WebProcess
Summary: Web Inspector: Allow Remote Inspector to entitlement check UIProcess through ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-30 16:49 PDT by Joseph Pecoraro
Modified: 2014-05-09 18:45 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (22.10 KB, patch)
2014-04-30 17:32 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-04-30 16:49:54 PDT 
When we have a proxy application like WebProcess holding WebViews for a UIProcess we only want to show the views if the UIProcess has the proper entitlements. Provide a path to pass the UIProcess audit_token (and pid) information on to webinspectord.

Part of: <rdar://problem/16180430>
Comment 1 Joseph Pecoraro 2014-04-30 17:32:07 PDT 
Created attachment 230547 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-04-30 17:35:00 PDT 
Attachment 230547 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:544:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/inspector/remote/RemoteInspector.h:64:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/inspector/remote/RemoteInspector.h:67:  The parameter name "pid" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2014-05-09 18:45:02 PDT 
<http://trac.webkit.org/changeset/168565>