Bug 132341 - [CSS Grid Layout] Wrap some specific grid code under compilation flag
Summary: [CSS Grid Layout] Wrap some specific grid code under compilation flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2014-04-29 09:55 PDT by Manuel Rego Casasnovas
Modified: 2014-04-30 08:13 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.60 KB, patch)
2014-04-29 09:56 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (5.62 KB, patch)
2014-04-29 09:58 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Path for landing. (5.77 KB, patch)
2014-04-30 00:45 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2014-04-29 09:55:44 PDT
[CSS Grid Layout] Wrap some specific grid code under compilation flag
Comment 1 Manuel Rego Casasnovas 2014-04-29 09:56:22 PDT
Created attachment 230383 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2014-04-29 09:58:08 PDT
Created attachment 230384 [details]
Patch

Re-upload with the bug link in the ChangeLog entry.
Comment 3 Benjamin Poulain 2014-04-30 00:08:16 PDT
Comment on attachment 230384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230384&action=review

Looks like a good idea.

> Source/WebCore/rendering/RenderBox.cpp:80
>  static OverrideSizeMap* gOverrideContainingBlockLogicalHeightMap = 0;
>  static OverrideSizeMap* gOverrideContainingBlockLogicalWidthMap = 0;

You can also replace those zero by nullptr.
Comment 4 Manuel Rego Casasnovas 2014-04-30 00:45:16 PDT
Created attachment 230468 [details]
Path for landing.
Comment 5 WebKit Commit Bot 2014-04-30 01:23:28 PDT
Comment on attachment 230468 [details]
Path for landing.

Clearing flags on attachment: 230468

Committed r167988: <http://trac.webkit.org/changeset/167988>
Comment 6 WebKit Commit Bot 2014-04-30 01:23:33 PDT
All reviewed patches have been landed.  Closing bug.