Bug 131889 - Incomplete body painting when using blend modes
Summary: Incomplete body painting when using blend modes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Blocks: 95614
  Show dependency treegraph
Reported: 2014-04-19 10:57 PDT by Simon Fraser (smfr)
Modified: 2014-04-25 01:05 PDT (History)
10 users (show)

See Also:

Testcase (1.13 KB, text/html)
2014-04-19 10:57 PDT, Simon Fraser (smfr)
no flags Details
simplified version (233 bytes, text/html)
2014-04-20 20:54 PDT, Rik Cabanier
no flags Details
Patch (3.83 KB, patch)
2014-04-24 23:16 PDT, Ion Rosca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-04-19 10:57:41 PDT
Created attachment 229736 [details]

Attached testcase (fix it to point to a local copy of ducky.png) shows a bug where the body background is only partially painted. It flashes horribly when hovering the boxes.
Comment 1 Simon Fraser (smfr) 2014-04-19 10:58:36 PDT
This is a blocker to Safari shipping blend modes.

Comment 2 Rik Cabanier 2014-04-20 20:54:11 PDT
Created attachment 229781 [details]
simplified version

even simpler version. This has to be a recent break since basic content is now drawing incorrectly.
Comment 3 Rik Cabanier 2014-04-20 23:14:03 PDT
It looks like this was caused by https://bugs.webkit.org/show_bug.cgi?id=130892
Comment 4 Mihnea Ovidenie 2014-04-23 10:23:28 PDT
(In reply to comment #3)
> It looks like this was caused by https://bugs.webkit.org/show_bug.cgi?id=130892

Nope, it's https://bugs.webkit.org/show_bug.cgi?id=129154.
Comment 5 Ion Rosca 2014-04-24 02:24:47 PDT
I'm looking into it.
Comment 6 Ion Rosca 2014-04-24 23:16:44 PDT
Created attachment 230143 [details]
Comment 7 Ion Rosca 2014-04-24 23:25:35 PDT
The patch I attached avoids creating a transparency layer for the root renderer that has unisolated blending descendants. However, the issue with background being painted incompletely is not fixed for other reasons that trigger transparency layers on the document element: opacity, mask or mix-blend-mode. This issue is reported here: https://bugs.webkit.org/show_bug.cgi?id=75460.
Comment 8 WebKit Commit Bot 2014-04-25 01:04:57 PDT
Comment on attachment 230143 [details]

Clearing flags on attachment: 230143

Committed r167796: <http://trac.webkit.org/changeset/167796>
Comment 9 WebKit Commit Bot 2014-04-25 01:05:02 PDT
All reviewed patches have been landed.  Closing bug.