Bug 13184 - HTMLImageElement longdesc should be complete resolved URL
Summary: HTMLImageElement longdesc should be complete resolved URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-24 15:17 PDT by Nicholas Shanks
Modified: 2007-03-31 03:24 PDT (History)
0 users

See Also:

Attachments
fix (952 bytes, patch)
2007-03-24 15:21 PDT, Nicholas Shanks 		no flags Details | Formatted Diff | Diff
now includes test case (4.04 KB, patch)
2007-03-24 16:31 PDT, Nicholas Shanks 		no flags Details | Formatted Diff | Diff
changed blurb of test's self description (4.01 KB, patch)
2007-03-24 16:34 PDT, Nicholas Shanks 		no flags Details | Formatted Diff | Diff
bugger, forgot to update expected results too (3.98 KB, patch)
2007-03-24 16:46 PDT, Nicholas Shanks 		darin: review-
Details | Formatted Diff | Diff
addresses darin's issue (4.24 KB, patch)
2007-03-25 04:17 PDT, Nicholas Shanks 		adele: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Shanks 2007-03-24 15:17:34 PDT 
Attached
Comment 1 Nicholas Shanks 2007-03-24 15:21:15 PDT 
Created attachment 13801 [details]
fix
Comment 2 Nicholas Shanks 2007-03-24 16:31:06 PDT 
Created attachment 13802 [details]
now includes test case
Comment 3 Nicholas Shanks 2007-03-24 16:34:22 PDT 
Created attachment 13803 [details]
changed blurb of test's self description
Comment 4 Nicholas Shanks 2007-03-24 16:46:26 PDT 
Created attachment 13804 [details]
bugger, forgot to update expected results too
Comment 5 Darin Adler 2007-03-24 20:00:45 PDT 
Comment on attachment 13804 [details]
bugger, forgot to update expected results too

Looks fine.

Also need to change HTMLImageElement::isURLAttribute to return true for longdescAttr. I noticed that by comparing with the handling of lowsrcAttr.

review- so you can fix that
Comment 6 Nicholas Shanks 2007-03-25 04:17:31 PDT 
Created attachment 13811 [details]
addresses darin's issue
Comment 7 Alexey Proskuryakov 2007-03-31 03:24:10 PDT 
Committed revision 20637.