Bug 131697 - Move DOM timer throttling out of the page throttler
Summary: Move DOM timer throttling out of the page throttler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 131696
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-15 14:50 PDT by Stephanie Lewis
Modified: 2014-04-19 14:35 PDT (History)
2 users (show)

See Also:


Attachments
patch (8.23 KB, patch)
2014-04-15 14:50 PDT, Stephanie Lewis
no flags Details | Formatted Diff | Diff
rebased patch (8.23 KB, patch)
2014-04-16 17:15 PDT, Stephanie Lewis
no flags Details | Formatted Diff | Diff
rebased patch for real (8.27 KB, patch)
2014-04-16 17:19 PDT, Stephanie Lewis
no flags Details | Formatted Diff | Diff
patch 4 (8.33 KB, patch)
2014-04-16 17:27 PDT, Stephanie Lewis
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2014-04-15 14:50:37 PDT
Created attachment 229405 [details]
patch

DOM timer throttling is currently part of the page throttler which uses per process state and per page state to determine when to throttle.  This led us to being overly conservative when turning DOM throttling off.  It should only respond to view state changes.

Additionally since creating extra Page Throttlers for WebKit1 views and SVG images caused bugs in tracking state we'll reserve the Page Throttler for WebKit2 views.  To avoid regressing we should move DOM timer throttling back to the page.

<rdar://problem/16473004> Throttling DOM timers should be per-page, not per-process
Comment 1 Darin Adler 2014-04-16 10:37:02 PDT
Comment on attachment 229405 [details]
patch

Patch didn’t apply. Could you post a new one that is rebased so it does apply?
Comment 2 Stephanie Lewis 2014-04-16 17:15:56 PDT
Created attachment 229501 [details]
rebased patch
Comment 3 Stephanie Lewis 2014-04-16 17:19:18 PDT
Created attachment 229503 [details]
rebased patch for real

oops that was the original patch
Comment 4 Stephanie Lewis 2014-04-16 17:27:38 PDT
Created attachment 229505 [details]
patch 4

Reversed the order of this patch and https://bugs.webkit.org/show_bug.cgi?id=131696 so it will apply cleanly
Comment 5 Gavin Barraclough 2014-04-17 20:06:18 PDT
Comment on attachment 229505 [details]
patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=229505&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests since itâs not web exposed.

unicode character in change log.
Comment 6 Stephanie Lewis 2014-04-18 17:50:30 PDT
Committed http://trac.webkit.org/changeset/167522
Comment 7 Darin Adler 2014-04-19 14:35:12 PDT
Comment on attachment 229505 [details]
patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=229505&action=review

>> Source/WebCore/ChangeLog:9
>> +        No new tests since itâs not web exposed.
> 
> unicode character in change log.

Such characters are OK in Subversion and git, just not in the bugs.webkit.org patch review tool!