Bug 131671 - REGRESSION(r167199): Caused a DYEBench regression and does not seem to improve perf on relevant websites (Requested by rniwa on #webkit).
Summary: REGRESSION(r167199): Caused a DYEBench regression and does not seem to improv...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 131083
  Show dependency tree / graph
 
Reported: 2014-04-15 00:58 PDT by WebKit Commit Bot
Modified: 2022-03-01 02:55 PST (History)
16 users (show)

See Also:

Attachments
ROLLOUT of r167199 (108.08 KB, patch)
2014-04-15 00:58 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2014-04-15 00:58:07 PDT 
http://trac.webkit.org/changeset/167199 broke the build:
Caused a DYEBench regression and does not seem to improve perf on relevant websites (Requested by rniwa on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2014-04-15 00:58:51 PDT 
Created attachment 229360 [details]
ROLLOUT of r167199

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2014-04-15 01:01:25 PDT 
Attachment 229360 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSBoundFunction.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 68 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2014-04-15 01:34:09 PDT 
Oliver, Geoff, Gavin: Please cq+ the patch if you think the rollout is the right solution here.  Unfortunately, I need to go sleep for now before mac EWS can build & test this patch.
Comment 4 Ryosuke Niwa 2014-04-15 09:21:24 PDT 
Due to http://trac.webkit.org/changeset/167297, we need to create a new rollout patch.