Bug 131636 - Function.bind itself is too slow
Summary: Function.bind itself is too slow
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on: 131666
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-14 14:59 PDT by Oliver Hunt
Modified: 2014-04-15 00:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (15.67 KB, patch)
2014-04-14 15:01 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (14.76 KB, patch)
2014-04-14 15:01 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-04-14 14:59:09 PDT
Function.bind itself is too slow
Comment 1 Oliver Hunt 2014-04-14 15:01:14 PDT
Created attachment 229307 [details]
Patch
Comment 2 Oliver Hunt 2014-04-14 15:01:46 PDT
Created attachment 229308 [details]
Patch
Comment 3 Geoffrey Garen 2014-04-14 15:03:24 PDT
Comment on attachment 229308 [details]
Patch

r=me
Comment 4 Oliver Hunt 2014-04-14 15:06:11 PDT
Committed r167272: <http://trac.webkit.org/changeset/167272>
Comment 5 Alexey Proskuryakov 2014-04-14 23:10:57 PDT
This change broke multiple tests, and EWS saw that. Please do click on yellow bubbles before landing, even if they didn't turn red yet.

Broken tests:

js/dom/function-bind.html
js/regress/function-bind-create.html
fast/canvas/webgl/typed-arrays-in-workers.html
webgl/1.0.2/conformance/typedarrays/typed-arrays-in-workers.html

Will roll out.
Comment 6 WebKit Commit Bot 2014-04-14 23:11:44 PDT
Re-opened since this is blocked by bug 131666
Comment 7 Geoffrey Garen 2014-04-15 00:14:11 PDT
perf.webkit.org measured a 1% DYEB regression from this patch.