Bug 131554 - Web Replay: code generator should consider enclosing class when computing duplicate type names
Summary: Web Replay: code generator should consider enclosing class when computing dup...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks: 131043
  Show dependency tree / graph
 
Reported: 2014-04-11 12:05 PDT by Brian Burg
Modified: 2014-04-11 17:25 PDT (History)
4 users (show)

See Also:

Attachments
the patch (16.51 KB, patch)
2014-04-11 12:31 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-11 12:05:23 PDT 
With the current implementation, it will complain about duplicates in cases like the enums PlatformEvent::Type and FormDataElement::Type.
Comment 1 Brian Burg 2014-04-11 12:31:44 PDT 
Created attachment 229152 [details]
the patch
Comment 2 WebKit Commit Bot 2014-04-11 17:25:37 PDT 
Comment on attachment 229152 [details]
the patch

Clearing flags on attachment: 229152

Committed r167174: <http://trac.webkit.org/changeset/167174>
Comment 3 WebKit Commit Bot 2014-04-11 17:25:39 PDT 
All reviewed patches have been landed.  Closing bug.