Bug 131534 - [GTK] Layout Test media/media-ended.html is flaky
Summary: [GTK] Layout Test media/media-ended.html is flaky
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
Keywords: InRadar
Depends on:
Reported: 2014-04-11 04:10 PDT by Enrique Ocaña
Modified: 2017-09-27 12:52 PDT (History)
7 users (show)

See Also:

Patch (2.30 KB, patch)
2017-08-31 08:00 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2017-09-01 01:26 PDT, Ms2ger (he/him; ⌚ UTC+1/+2)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2014-04-11 04:10:19 PDT
The following layout test is flaky on GTK Linux 64-bit Release

media/media-ended.html [ Timeout Pass ]

The flakiness ins't linked to any particular commit:

Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-31 08:00:23 PDT
Created attachment 319461 [details]
Comment 2 Carlos Alberto Lopez Perez 2017-08-31 12:39:48 PDT
Comment on attachment 319461 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=319461&action=review

> LayoutTests/media/media-ended.html:17
> -                audio.src = findMediaFile("audio", "content/silence")
> +                audio.src = findMediaFile("audio", "content/short")

good catch, but "short" is really short.. only 27 msecs! Not sure if is right to use such short audio file here.

The main reason why this test was timing out on GTK bot, but not on other port bots was because our aggressive time out values.
We raised that on r218270 (and is still lower than on Mac ports).

I have checked with wktesthunter that this test is now passing always since r218270.
So I think we can just remove the flaky expectation and close this bug (leaving the test as it was originally wrote with the silence audio file).
Comment 3 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-09-01 01:26:42 PDT
Created attachment 319585 [details]
Comment 4 Michael Catanzaro 2017-09-01 04:19:35 PDT
Comment on attachment 319585 [details]

Good catch Carlos!
Comment 5 WebKit Commit Bot 2017-09-01 04:47:48 PDT
Comment on attachment 319585 [details]

Clearing flags on attachment: 319585

Committed r221476: <http://trac.webkit.org/changeset/221476>
Comment 6 WebKit Commit Bot 2017-09-01 04:47:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:52:32 PDT