Bug 131427 – [EFL] Change font path for DumpRenderTree and WebKitTestRunner

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

Since r166973, WebKit/Gtk changed font directory.

[Ryuan Choi]

Created attachment 228935 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 228935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review

> Tools/DumpRenderTree/PlatformEfl.cmake:80
> +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts"

I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path.

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 228935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review
> 
> > Tools/DumpRenderTree/PlatformEfl.cmake:80
> > +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts"
> 
> I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path.

Yes, after removed GtKLauncher, fonts are just moved to WebKitTestRunner/gtk/fonts.
I don't think that it is good to copy them to efl specific folder.
And we don't have good fonts for efl port yet.

One solution is moving fonts to better place but I don't have idea.

[Martin Robinson]

Comment on attachment 228935 [details]
Patch

Sorry about the breakage! I had no idea that EFL used our fonts directory.

[Gyuyoung Kim]

Comment on attachment 228935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review

> Tools/DumpRenderTree/PlatformEfl.cmake:78
>  # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory

BTW, I think we can delete this FIXME: comment. Bug 81475 was closed.

>>> Tools/DumpRenderTree/PlatformEfl.cmake:80
>>> +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts"
>> 
>> I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path.
> 
> Yes, after removed GtKLauncher, fonts are just moved to WebKitTestRunner/gtk/fonts.
> I don't think that it is good to copy them to efl specific folder.
> And we don't have good fonts for efl port yet.
> 
> One solution is moving fonts to better place but I don't have idea.

I think we need to add a comment. For example,

"FIXME: EFL port needs to have own test font and font configure instead of gtk test font in future"

> Tools/WebKitTestRunner/PlatformEfl.cmake:79
>  # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory

ditto.

[Gyuyoung Kim]

(In reply to comment #4)
> (From update of attachment 228935 [details])
> Sorry about the breakage! I had no idea that EFL used our fonts directory.

I wish EFL port has own test font in future. So, I would like to land this patch with a comment.

[Ryuan Choi]

(In reply to comment #5)
> (From update of attachment 228935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review
> 
> > Tools/DumpRenderTree/PlatformEfl.cmake:78
> >  # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory
> 
> BTW, I think we can delete this FIXME: comment. Bug 81475 was closed.
> 

Oh, right but without fixing "hardcode the directory". :(
Bug 81475 just fixed the issues about jhbuild.

I will remove url only and follow it in the another bug.

> >>> Tools/DumpRenderTree/PlatformEfl.cmake:80
> >>> +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts"
> >> 
> >> I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path.
> > 
> > Yes, after removed GtKLauncher, fonts are just moved to WebKitTestRunner/gtk/fonts.
> > I don't think that it is good to copy them to efl specific folder.
> > And we don't have good fonts for efl port yet.
> > 
> > One solution is moving fonts to better place but I don't have idea.
> 
> I think we need to add a comment. For example,
> 
> "FIXME: EFL port needs to have own test font and font configure instead of gtk test font in future"
> 
> > Tools/WebKitTestRunner/PlatformEfl.cmake:79
> >  # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory
> 
> ditto.

OK, I will.

[Ryuan Choi]

Created attachment 228946 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 228946 [details]
Patch

Clearing flags on attachment: 228946

Committed r167004: <http://trac.webkit.org/changeset/167004>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.