AXPress fails when trying to select a TV provider from http://www.cnn.com/video/data/2.0/video/cvptve/cvpstream1.html We need to make AXPress more reliable by 1) Using the element that is focused as the target of the event 2) Search for the inner mode control object when dispatching the event
<rdar://problem/16562107>
Created attachment 228934 [details] patch
Created attachment 228947 [details] patch
Attachment 228947 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228947 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228947&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:42 > +#include "HitTestResult.h" This placement seems to make the style checker unhappy > Source/WebCore/accessibility/AccessibilityObject.cpp:723 > + // The presencen of the actionElement will confirm whether we should even attempt a press. s/presencen/presence > Source/WebCore/accessibility/AccessibilityObject.cpp:750 > + Element* element = this->element(); > + Element* pressElement = element; You can use just one variable here, pressElement, assigned to this->element()
http://trac.webkit.org/changeset/167024