Bug 131426 - AX: Make AXPress much more reliable on the Web
Summary: AX: Make AXPress much more reliable on the Web
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: chris fleizach
Keywords: InRadar
Depends on:
Blocks: 135689
  Show dependency treegraph
Reported: 2014-04-08 21:57 PDT by chris fleizach
Modified: 2014-08-06 23:16 PDT (History)
9 users (show)

See Also:

patch (13.41 KB, patch)
2014-04-08 22:02 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (13.65 KB, patch)
2014-04-08 23:47 PDT, chris fleizach
mario: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2014-04-08 21:57:48 PDT
AXPress fails when trying to select a TV provider from

We need to make AXPress more reliable by 
1) Using the element that is focused as the target of the event
2) Search for the inner mode control object when dispatching the event
Comment 1 Radar WebKit Bug Importer 2014-04-08 21:57:57 PDT
Comment 2 chris fleizach 2014-04-08 22:02:17 PDT
Created attachment 228934 [details]
Comment 3 chris fleizach 2014-04-08 23:47:35 PDT
Created attachment 228947 [details]
Comment 4 WebKit Commit Bot 2014-04-08 23:48:56 PDT
Attachment 228947 [details] did not pass style-queue:

ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Mario Sanchez Prada 2014-04-09 07:53:01 PDT
Comment on attachment 228947 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=228947&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:42
> +#include "HitTestResult.h"

This placement seems to make the style checker unhappy

> Source/WebCore/accessibility/AccessibilityObject.cpp:723
> +    // The presencen of the actionElement will confirm whether we should even attempt a press.


> Source/WebCore/accessibility/AccessibilityObject.cpp:750
> +    Element* element = this->element();
> +    Element* pressElement = element;

You can use just one variable here, pressElement, assigned to this->element()
Comment 6 chris fleizach 2014-04-09 11:42:49 PDT