Bug 131421 – Fix EFL Build errors since r166975.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Hyowon Kim]

EFL Build fix since r166956

[Hyowon Kim]

Created attachment 228930 [details]
Patch

[Ryuan Choi]

Comment on attachment 228930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228930&action=review

> Source/WebKit2/PlatformEfl.cmake:189
> +    WebProcess/WebPage/PageOverlayController.cpp

I think that this is not EFL specific

[Gyuyoung Kim]

Comment on attachment 228930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228930&action=review

> Source/WebKit2/ChangeLog:3
> +        EFL Build fix since r166956

I don't know why r166956 is involved in this build break. 

It looks the r166956 make bmalloc.

http://trac.webkit.org/changeset/166956

[Hyowon Kim]

(In reply to comment #3)
> (From update of attachment 228930 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228930&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        EFL Build fix since r166956
> 
> I don't know why r166956 is involved in this build break. 
> 
> It looks the r166956 make bmalloc.
> 
> http://trac.webkit.org/changeset/166956

Sorry r166975.

[Hyowon Kim]

Created attachment 228932 [details]
Patch

[Hyowon Kim]

I've filed a new bug 131425 to add additional implementation for page overlay.

[Gyuyoung Kim]

Comment on attachment 228932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228932&action=review

> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:73
> +        m_webPage->uninstallPageOverlay(m_overlay, PageOverlay::FadeMode::Fade);

BTW, should we modify this line ?

[Gyuyoung Kim]

Comment on attachment 228932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228932&action=review

> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:73
> +        m_webPage->uninstallPageOverlay(m_overlay, PageOverlay::FadeMode::Fade);

BTW, should we modify this line ?

[Hyowon Kim]

(In reply to comment #8)
> (From update of attachment 228932 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228932&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:73
> > +        m_webPage->uninstallPageOverlay(m_overlay, PageOverlay::FadeMode::Fade);
> 
> BTW, should we modify this line ?

Yes, the second parameter was changed to enum class FadeMode.

[WebKit Commit Bot]

Comment on attachment 228932 [details]
Patch

Clearing flags on attachment: 228932

Committed r167002: <http://trac.webkit.org/changeset/167002>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.