Bug 131371 - Rename Clipboard to DataTransfer
Summary: Rename Clipboard to DataTransfer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-08 10:44 PDT by Alexey Proskuryakov
Modified: 2014-04-08 15:08 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (206.06 KB, patch)
2014-04-08 10:54 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
with fixes (225.90 KB, patch)
2014-04-08 12:15 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
updated to ToT (223.56 KB, patch)
2014-04-08 13:45 PDT, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-04-08 10:44:52 PDT
DataTransfer is the name from HTML5, and it's so much better than the confusing Clipboard one.
Comment 1 Alexey Proskuryakov 2014-04-08 10:54:19 PDT
Created attachment 228855 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-04-08 10:55:29 PDT
Attachment 228855 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ClipboardEvent.h:31:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/DataTransferAccessPolicy.h:25:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/DragController.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/page/DragController.cpp:191:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/DragController.cpp:601:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/DragController.cpp:613:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/page/DragController.cpp:810:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/dom/DataTransfer.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/DerivedSources.cpp:106:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/page/EventHandler.cpp:3317:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/dom/MouseEvent.cpp:118:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.cpp:128:  Wrong number of spaces before statement. (expected: 27)  [whitespace/indent] [4]
Total errors found: 12 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-04-08 12:15:28 PDT
Created attachment 228866 [details]
with fixes
Comment 4 Alexey Proskuryakov 2014-04-08 13:45:09 PDT
Created attachment 228880 [details]
updated to ToT
Comment 5 WebKit Commit Bot 2014-04-08 13:46:37 PDT
Attachment 228880 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ClipboardEvent.h:31:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/page/DragController.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/DataTransfer.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/DerivedSources.cpp:106:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:118:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.cpp:128:  Wrong number of spaces before statement. (expected: 27)  [whitespace/indent] [4]
Total errors found: 6 in 66 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alexey Proskuryakov 2014-04-08 13:53:04 PDT
Gtk/Efl failures sound like a result of CMake caching.
Comment 7 Alexey Proskuryakov 2014-04-08 15:08:47 PDT
Committed <http://trac.webkit.org/r166965>.