RESOLVED FIXED 131371
Rename Clipboard to DataTransfer 
https://bugs.webkit.org/show_bug.cgi?id=131371
Summary Rename Clipboard to DataTransfer
Alexey Proskuryakov
Reported 2014-04-08 10:44:52 PDT
DataTransfer is the name from HTML5, and it's so much better than the confusing Clipboard one.
Attachments
proposed patch (206.06 KB, patch)
2014-04-08 10:54 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
with fixes (225.90 KB, patch)
2014-04-08 12:15 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
updated to ToT (223.56 KB, patch)
2014-04-08 13:45 PDT, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-04-08 10:54:19 PDT
Created attachment 228855 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-04-08 10:55:29 PDT
Attachment 228855 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ClipboardEvent.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/DataTransferAccessPolicy.h:25: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/DragController.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/DragController.cpp:191: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/page/DragController.cpp:601: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/page/DragController.cpp:613: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/page/DragController.cpp:810: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/dom/DataTransfer.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/DerivedSources.cpp:106: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/EventHandler.cpp:3317: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/dom/MouseEvent.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/MouseEvent.cpp:128: Wrong number of spaces before statement. (expected: 27) [whitespace/indent] [4] Total errors found: 12 in 56 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2014-04-08 12:15:28 PDT
Created attachment 228866 [details] with fixes
Alexey Proskuryakov
Comment 4 2014-04-08 13:45:09 PDT
Created attachment 228880 [details] updated to ToT
WebKit Commit Bot
Comment 5 2014-04-08 13:46:37 PDT
Attachment 228880 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ClipboardEvent.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/DragController.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/DataTransfer.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/DerivedSources.cpp:106: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/MouseEvent.cpp:128: Wrong number of spaces before statement. (expected: 27) [whitespace/indent] [4] Total errors found: 6 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 6 2014-04-08 13:53:04 PDT
Gtk/Efl failures sound like a result of CMake caching.
Alexey Proskuryakov
Comment 7 2014-04-08 15:08:47 PDT
Committed <http://trac.webkit.org/r166965>.
Note You need to log in before you can comment on or make changes to this bug.