Bug 131363 – [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Éva Balázsfalvi]

In case of multiple bug rollout, all bugs should be reopened, not only the oldest one

[Éva Balázsfalvi]

Created attachment 228845 [details]
Patch

[Alexey Proskuryakov]

What was the situation motivating this change?

I think that most of the time, additional bugs are follow-ups that are meaningless when the original patch gets rolled out.

[Csaba Osztrogonác]

(In reply to comment #2)
> What was the situation motivating this change?
> 
> I think that most of the time, additional bugs are follow-ups that are meaningless when the original patch gets rolled out.

Most of the time "multi patch rollouts" reverts a revision with a bug 
report and several follow patches which don't have bug reports at all.

But rarely there is a changeset and later a follow-up fix or
not a fix, but something depends on it. If you rollout both of
these changes, the authors of the second bug doesn't get any
automatical notification now. It is very rare, but it can be
annoying.

[Csaba Osztrogonác]

Comment on attachment 228845 [details]
Patch

The fix looks good to me more or less. 

But after checking it thoroughly, it solves only the case when you rollout patches with 
webkit-patch rollout, but it doesn't when you do it with webkit-patch create-rollout.
Sheriffbot uses the create-rollout too, so this code path should be fixed too.

[Csaba Osztrogonác]

The bugs of rolled out patches can be blocked and reopened 
from createbug.py, but we need to make it handle more bug ids.

[Éva Balázsfalvi]

Created attachment 231571 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 231571 [details]
Patch

Clearing flags on attachment: 231571

Committed r168968: <http://trac.webkit.org/changeset/168968>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.