Bug 131337 - Web Replay: save and restore initial main frame size
Summary: Web Replay: save and restore initial main frame size
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: WebReplay
  Show dependency treegraph
 
Reported: 2014-04-07 18:42 PDT by Brian Burg
Modified: 2017-07-10 13:59 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-07 18:42:19 PDT
This is something I haven't prototyped before, so I would appreciate thoughts on how to (not) implement it.

The motivation here is simple: when JavaScript queries the results of layout, we want that to be deterministic. If the size of the FrameView/document/etc is not the same on replay as it was when the recording was created, then layout queries are unlikely to be deterministic.

A secondary goal is that the window size looks the same on capture and replay, possibly by telling the embedder it needs to resize the view. Showing the intended window size lets the inspector visualize replayed user inputs with overlays. If the window can't actually be resized, we still want layout to use the original size even if not all of the content can be displayed.

It would also be nice to make resizing work with capture and replay. Setting the initial size could be treated as a resize command.
Comment 1 Timothy Hatcher 2014-04-08 11:59:32 PDT
A naive first step should be a simple as saving page->chrome().windowRect() and restoring it with page->chrome().setWindowRect(). I'm not sure where the right hook would be to capture user resizes.
Comment 2 Brian Burg 2014-08-27 09:54:24 PDT
We probably want to do this through WK2.
Comment 3 Brian Burg 2017-07-10 13:59:35 PDT
Closing web replay-related bugs until we resume working on the feature again.