Bug 131329 - [iOS][WK2] Implement the update of content offset on animated resize
Summary: [iOS][WK2] Implement the update of content offset on animated resize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-07 17:09 PDT by Benjamin Poulain
Modified: 2014-04-07 19:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2014-04-07 17:13 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (8.11 KB, patch)
2014-04-07 18:27 PDT, Benjamin Poulain 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-04-07 17:09:31 PDT 
[iOS][WK2] Implement the update of content offset on animated resize
Comment 1 Benjamin Poulain 2014-04-07 17:13:36 PDT 
Created attachment 228779 [details]
Patch
Comment 2 Benjamin Poulain 2014-04-07 18:27:59 PDT 
Created attachment 228788 [details]
Patch
Comment 3 Tim Horton 2014-04-07 18:45:08 PDT 
Comment on attachment 228788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228788&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1200
> +    CGSize contentSizeInContentViewCoordinate = [_contentView bounds].size;

coordinate*s*

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1215
> +    CGFloat oldWebViewWidthInContentViewCoordinate = oldBounds.size.width / contentZoomScale(self);

so many "s" missing
Comment 4 Benjamin Poulain 2014-04-07 19:13:34 PDT 
Committed r166905: <http://trac.webkit.org/changeset/166905>