Bug 131322 - [iOS] Media controls should resize as the user zooms
Summary: [iOS] Media controls should resize as the user zooms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on: 131319
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-07 16:01 PDT by Dean Jackson
Modified: 2022-10-10 14:37 PDT (History)
13 users (show)

See Also:

Attachments
Patch (8.57 KB, patch)
2014-04-07 19:13 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (13.90 KB, patch)
2014-04-07 19:16 PDT, Dean Jackson 		eric.carlson: review+
Details | Formatted Diff | Diff
Landing Patch (13.90 KB, patch)
2014-04-08 11:09 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Landing Patch 2 (14.17 KB, patch)
2014-04-08 11:46 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Landing Patch 3 (13.47 KB, patch)
2014-04-09 15:19 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Another patch for landing (13.24 KB, patch)
2014-04-09 16:19 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (13.99 KB, patch)
2014-04-09 16:54 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-04-07 16:01:42 PDT 
On iOS we want the media controls to remain at a constant size as the user zooms (or the viewport is set). 

<rdar://problem/15349818>
Comment 1 Dean Jackson 2014-04-07 19:13:03 PDT 
Created attachment 228793 [details]
Patch
Comment 2 Dean Jackson 2014-04-07 19:13:43 PDT 
Comment on attachment 228793 [details]
Patch

Wrong patch :|
Comment 3 Dean Jackson 2014-04-07 19:16:40 PDT 
Created attachment 228795 [details]
Patch
Comment 4 Dean Jackson 2014-04-07 19:17:15 PDT 
This patch will not compile without 131319
Comment 5 Dean Jackson 2014-04-08 11:09:13 PDT 
Created attachment 228859 [details]
Landing Patch
Comment 6 Dean Jackson 2014-04-08 11:46:26 PDT 
Created attachment 228861 [details]
Landing Patch 2
Comment 7 Eric Carlson 2014-04-09 15:19:14 PDT 
Created attachment 228992 [details]
Landing Patch 3
Comment 8 Eric Carlson 2014-04-09 16:19:17 PDT 
Created attachment 228999 [details]
Another patch for landing
Comment 9 Dean Jackson 2014-04-09 16:54:53 PDT 
Created attachment 229000 [details]
Patch

THIS WILL WORK
Comment 10 WebKit Commit Bot 2014-04-09 18:06:58 PDT 
Comment on attachment 229000 [details]
Patch

Clearing flags on attachment: 229000

Committed r167057: <http://trac.webkit.org/changeset/167057>
Comment 11 Ahmad Saleem 2022-10-10 14:36:58 PDT 
Landed and didn't backed out:

https://github.com/WebKit/WebKit/commit/ff603fd36643a06aa4abd949c7892c2e31cb203c

Marking this as "RESOLVED FIXED".
Comment 12 Radar WebKit Bug Importer 2022-10-10 14:37:18 PDT 
<rdar://problem/100997951>