Bug 131261 - [EFL][WK1] Apply override and final keyword for ChromeClientEfl
Summary: [EFL][WK1] Apply override and final keyword for ChromeClientEfl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-04 22:43 PDT by Ryuan Choi
Modified: 2014-04-05 05:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.82 KB, patch)
2014-04-04 22:48 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-04-04 22:43:36 PDT 
ChromeClientEfl has unnecessary virtual methods which is already removed from parent class.
Comment 1 Ryuan Choi 2014-04-04 22:48:50 PDT 
Created attachment 228656 [details]
Patch
Comment 2 Gyuyoung Kim 2014-04-05 02:19:10 PDT 
Comment on attachment 228656 [details]
Patch

LGTM
Comment 3 WebKit Commit Bot 2014-04-05 05:25:24 PDT 
Comment on attachment 228656 [details]
Patch

Clearing flags on attachment: 228656

Committed r166831: <http://trac.webkit.org/changeset/166831>
Comment 4 WebKit Commit Bot 2014-04-05 05:25:29 PDT 
All reviewed patches have been landed.  Closing bug.