WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 131261
[EFL][WK1] Apply override and final keyword for ChromeClientEfl
https://bugs.webkit.org/show_bug.cgi?id=131261
Summary
[EFL][WK1] Apply override and final keyword for ChromeClientEfl
Ryuan Choi
Reported
2014-04-04 22:43:36 PDT
ChromeClientEfl has unnecessary virtual methods which is already removed from parent class.
Attachments
Patch
(13.82 KB, patch)
2014-04-04 22:48 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2014-04-04 22:48:50 PDT
Created
attachment 228656
[details]
Patch
Gyuyoung Kim
Comment 2
2014-04-05 02:19:10 PDT
Comment on
attachment 228656
[details]
Patch LGTM
WebKit Commit Bot
Comment 3
2014-04-05 05:25:24 PDT
Comment on
attachment 228656
[details]
Patch Clearing flags on attachment: 228656 Committed
r166831
: <
http://trac.webkit.org/changeset/166831
>
WebKit Commit Bot
Comment 4
2014-04-05 05:25:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug