WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
131164
[WK2] Fix !ENABLE(BLOB) build
https://bugs.webkit.org/show_bug.cgi?id=131164
Summary
[WK2] Fix !ENABLE(BLOB) build
Martin Hodovan
Reported
2014-04-03 08:41:27 PDT
[WK2] Fix !ENABLE(BLOB) build
Attachments
Proposed patch
(4.14 KB, patch)
2014-04-03 08:46 PDT
,
Martin Hodovan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Hodovan
Comment 1
2014-04-03 08:46:06 PDT
Created
attachment 228510
[details]
Proposed patch
Alexey Proskuryakov
Comment 2
2014-04-03 09:25:59 PDT
Comment on
attachment 228510
[details]
Proposed patch r=me What is the purpose of not enabling BLOB, though? Should we just enable it unconditionally everywhere?
WebKit Commit Bot
Comment 3
2014-04-03 09:56:12 PDT
Comment on
attachment 228510
[details]
Proposed patch Clearing flags on attachment: 228510 Committed
r166728
: <
http://trac.webkit.org/changeset/166728
>
WebKit Commit Bot
Comment 4
2014-04-03 09:56:15 PDT
All reviewed patches have been landed. Closing bug.
Martin Hodovan
Comment 5
2014-04-04 06:13:29 PDT
(In reply to
comment #2
)
> (From update of
attachment 228510
[details]
) > What is the purpose of not enabling BLOB, though? Should we just enable it unconditionally everywhere?
The --minimal build is used for checking whether the guards are at the right places, and this patch was necessary to make it work properly. If no one is interested to build without BLOB, then probably we should remove the guards.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug