Bug 131164 - [WK2] Fix !ENABLE(BLOB) build
Summary: [WK2] Fix !ENABLE(BLOB) build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-03 08:41 PDT by Martin Hodovan
Modified: 2014-04-04 06:13 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (4.14 KB, patch)
2014-04-03 08:46 PDT, Martin Hodovan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Hodovan 2014-04-03 08:41:27 PDT
[WK2] Fix !ENABLE(BLOB) build
Comment 1 Martin Hodovan 2014-04-03 08:46:06 PDT
Created attachment 228510 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2014-04-03 09:25:59 PDT
Comment on attachment 228510 [details]
Proposed patch

r=me

What is the purpose of not enabling BLOB, though? Should we just enable it unconditionally everywhere?
Comment 3 WebKit Commit Bot 2014-04-03 09:56:12 PDT
Comment on attachment 228510 [details]
Proposed patch

Clearing flags on attachment: 228510

Committed r166728: <http://trac.webkit.org/changeset/166728>
Comment 4 WebKit Commit Bot 2014-04-03 09:56:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Martin Hodovan 2014-04-04 06:13:29 PDT
(In reply to comment #2)
> (From update of attachment 228510 [details])
> What is the purpose of not enabling BLOB, though? Should we just enable it unconditionally everywhere?

The --minimal build is used for checking whether the guards are at the right places,
and this patch was necessary to make it work properly. If no one is interested to
build without BLOB, then probably we should remove the guards.