Bug 131073 - Web Inspector: Remove InputAgent
Summary: Web Inspector: Remove InputAgent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2014-04-01 15:53 PDT by Timothy Hatcher
Modified: 2014-04-02 12:34 PDT (History)
5 users (show)

See Also:


Attachments
Patch (35.33 KB, patch)
2014-04-01 15:58 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (475.12 KB, application/zip)
2014-04-01 17:10 PDT, WebKit Commit Bot
no flags Details
Patch (41.21 KB, patch)
2014-04-02 11:41 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-04-01 15:53:36 PDT
Remove input agent. It is for a Chrome feature (device screen sharing) we don't have.
Comment 1 Timothy Hatcher 2014-04-01 15:58:11 PDT
Created attachment 228332 [details]
Patch
Comment 2 Joseph Pecoraro 2014-04-01 16:02:20 PDT
Comment on attachment 228332 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-04-01 17:10:33 PDT
Comment on attachment 228332 [details]
Patch

Rejecting attachment 228332 [details] from commit-queue.

New failing tests:
inspector-protocol/input/dispatchMouseEvent.html
inspector-protocol/input/dispatchKeyEvent.html
Full output: http://webkit-queues.appspot.com/results/6299962283393024
Comment 4 WebKit Commit Bot 2014-04-01 17:10:35 PDT
Created attachment 228344 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Timothy Hatcher 2014-04-02 11:41:21 PDT
Created attachment 228405 [details]
Patch
Comment 6 WebKit Commit Bot 2014-04-02 12:34:43 PDT
Comment on attachment 228405 [details]
Patch

Clearing flags on attachment: 228405

Committed r166657: <http://trac.webkit.org/changeset/166657>
Comment 7 WebKit Commit Bot 2014-04-02 12:34:46 PDT
All reviewed patches have been landed.  Closing bug.