Bug 130970 - [GTK] No longer build WebKit1 gtkdoc
Summary: [GTK] No longer build WebKit1 gtkdoc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 130899
  Show dependency tree / graph
 
Reported: 2014-03-31 08:46 PDT by Martin Robinson
Modified: 2014-04-01 08:14 PDT (History)
0 users

See Also:

Attachments
Patch (3.84 KB, patch)
2014-03-31 08:52 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-03-31 08:46:41 PDT 
We no longer need this.
Comment 1 Martin Robinson 2014-03-31 08:52:35 PDT 
Created attachment 228181 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-04-01 00:13:05 PDT 
Comment on attachment 228181 [details]
Patch

I think we should also update the build files, I think we have rules to generate the docs for webkit1 and webkit2, no?
Comment 3 Martin Robinson 2014-04-01 00:21:09 PDT 
(In reply to comment #2)
> (From update of attachment 228181 [details])
> I think we should also update the build files, I think we have rules to generate the docs for webkit1 and webkit2, no?

It's true that we are still generating the gtkdoc configuration file, but I think it makes sense to simply wait until we remove everything in the Source/WebKit/gtk directory instead of pulling apart the build files now.
Comment 4 Martin Robinson 2014-04-01 08:14:05 PDT 
Comment on attachment 228181 [details]
Patch

Clearing flags on attachment: 228181

Committed r166584: <http://trac.webkit.org/changeset/166584>
Comment 5 Martin Robinson 2014-04-01 08:14:09 PDT 
All reviewed patches have been landed.  Closing bug.