Bug 13091 - REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD
Summary: REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P1 Normal
Assignee: Nobody
URL: http://www.apple.com/buy/locator/inde...
Keywords: HasReduction, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2007-03-16 01:38 PDT by mitz
Modified: 2007-03-20 03:54 PDT (History)
2 users (show)

See Also:


Attachments
Screenshot (41.10 KB, image/png)
2007-03-16 01:39 PDT, mitz
no flags Details
Screenshot from Safari 2 (expected rendering) (41.11 KB, image/png)
2007-03-16 01:43 PDT, mitz
no flags Details
Test case (593 bytes, text/html)
2007-03-16 04:58 PDT, mitz
no flags Details
Add inline style from CSS rules only in AnnotateForInterchange mode (6.14 KB, patch)
2007-03-16 05:47 PDT, mitz
mrowe: review-
Details | Formatted Diff | Diff
Add inline style from CSS rules only in AnnotateForInterchange mode (9.25 KB, patch)
2007-03-19 00:47 PDT, mitz
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-03-16 01:38:57 PDT
To see the problem, open the URL and click the first store on the list on the left to bring up the HUD on the map. The "Address" and "Services" labels on the tabs should be white and centered vertically. Instead they are light blue and aligned with the top of the tab. There is also a 1-pixel wide gap across the HUD.
Comment 1 mitz 2007-03-16 01:39:27 PDT
Created attachment 13658 [details]
Screenshot
Comment 2 mitz 2007-03-16 01:43:51 PDT
Created attachment 13659 [details]
Screenshot from Safari 2 (expected rendering)
Comment 3 mitz 2007-03-16 03:25:49 PDT
Regressed in <http://trac.webkit.org/projects/webkit/changeset/20075>.
Comment 4 mitz 2007-03-16 04:58:10 PDT
Created attachment 13663 [details]
Test case
Comment 5 Mark Rowe (bdash) 2007-03-16 05:20:45 PDT
<rdar://problem/5068260>
Comment 6 mitz 2007-03-16 05:47:31 PDT
Created attachment 13664 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode
Comment 7 Mark Rowe (bdash) 2007-03-18 16:55:30 PDT
Landed in r20297.
Comment 8 Mark Rowe (bdash) 2007-03-18 19:05:23 PDT
And back out again in r20302.  This introduced layout test failures related to web archives.  <http://build.webkit.org/results/post-commit-powerpc-mac-os-x/6102/webarchive/> has the diffs.
Comment 9 mitz 2007-03-19 00:47:40 PDT
Created attachment 13702 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode

Added updated results for three webarchive tests that were missing from the previous patch. The new results are identical to the results prior to r20075.
Comment 10 mitz 2007-03-19 01:02:50 PDT
Comment on attachment 13702 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode

Testing webkit-reviews mail
Comment 11 mitz 2007-03-19 01:35:21 PDT
Comment on attachment 13702 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode

mitz denying bdash's request
Comment 12 Mark Rowe (bdash) 2007-03-19 01:40:21 PDT
Comment on attachment 13702 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode

Please sir, may I have another?
Comment 13 mitz 2007-03-19 01:42:29 PDT
Comment on attachment 13702 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode

mitz denying bdash
Comment 14 Mark Rowe (bdash) 2007-03-19 01:59:02 PDT
Comment on attachment 13702 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode

One more test of bugzilla emails.  Sorry for the mess!
Comment 15 mitz 2007-03-19 02:00:17 PDT
Comment on attachment 13702 [details]
Add inline style from CSS rules only in AnnotateForInterchange mode

no way!
Comment 16 Mark Rowe (bdash) 2007-03-19 06:02:16 PDT
And landed again in r20319. Thanks Mitz!
Comment 17 David Kilzer (:ddkilzer) 2007-03-20 03:54:53 PDT
(In reply to comment #9)
> Added updated results for three webarchive tests that were missing from the
> previous patch. The new results are identical to the results prior to r20075.

Nice!  I was wondering where all that extra style info came from.

http://trac.webkit.org/projects/webkit/changeset/20075
http://trac.webkit.org/projects/webkit/changeset/20319