Bug 13088 - REGRESSION(r19761-19779): Copy image no longer includes image address
Summary: REGRESSION(r19761-19779): Copy image no longer includes image address
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh Intel OS X 10.4
: P1 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2007-03-15 13:49 PDT by Denis Ahrens
Modified: 2007-03-16 00:05 PDT (History)
2 users (show)

See Also:


Attachments
Declare types only once (1.12 KB, patch)
2007-03-15 23:27 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Actually this one is better (3.87 KB, patch)
2007-03-15 23:46 PDT, Beth Dakin
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Ahrens 2007-03-15 13:49:19 PDT
When I copy an image to the clipboard with webkit the image is there but not the URL. When I do the same in Safari there is the image AND the URL. This is a REGRESSION!
Comment 1 Matt Lilek 2007-03-15 14:26:34 PDT
1. Load http://webkit.org/images/icon-gold.png
2. In ToT, right click and choose "Copy Image"
3. Open a new tab/window and paste into the address bar - nothing
4. Repeat in Safari 2.0.4 - the image address is pasted fine.

Viewing the clipboard with Clipboard Viewer (in the Developer Tools) shows a bunch of differences between what's copied from ToT and Safari 2.0.4.  Both have identical contents for NeXT TIFF v4.0 pasteboard type.  ToT includes a NeXT RTFD pasteboard type that shipping Safari does not.  For everything else (WebURLsWithTitlesPboardType, Apple URL pasteboard type, 'url', 'urln', NSStringPboardType, NeXT plain ascii pasteboard type, Apple PICT pasteboard type), ToT has nothing while shipping Safari fills all those in.
Comment 2 Denis Ahrens 2007-03-15 19:08:54 PDT
in Webkit r19761 it works like in Safari but in Webkit r19779 it does not.
Comment 3 Matt Lilek 2007-03-15 19:18:48 PDT
Thanks for regressing that Denis!

http://trac.webkit.org/projects/webkit/changeset/19764 looks to me to be the culprit.
Comment 4 Mark Rowe (bdash) 2007-03-15 22:21:34 PDT
<rdar://problem/5067927>
Comment 5 Beth Dakin 2007-03-15 23:27:28 PDT
Created attachment 13655 [details]
Declare types only once
Comment 6 Beth Dakin 2007-03-15 23:46:34 PDT
Created attachment 13656 [details]
Actually this one is better
Comment 7 Beth Dakin 2007-03-15 23:51:36 PDT
Comment on attachment 13656 [details]
Actually this one is better

Geoff reviewed this.
Comment 8 Beth Dakin 2007-03-16 00:05:16 PDT
Fixed in r20233.