Bug 130809 – Hook up -webkit-overflow-scrolling:touch for iOS WK2

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Hook up -webkit-overflow-scrolling:touch for iOS WK2

[Simon Fraser (smfr)]

Created attachment 227905 [details]
Patch

[Tim Horton]

Comment on attachment 227905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227905&action=review

> Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:61
> +        UIScrollView *scrollView = (UIScrollView *)[scrollLayer() delegate];

tiny eww

> Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:94
> +            layerOrView = adoptNS([[UIScrollView alloc] initWithFrame:CGRectZero]);

I vaguely remember being chastised for using initWithFrame:CGRectZero instead of init in the recent past, but I don't mind either way.

[Simon Fraser (smfr)]

https://trac.webkit.org/r166333

[Alexey Proskuryakov]

This broke a number of tests on Mac:

  platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html [ Failure ]
  platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html [ Failure ]
  platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html [ Failure ]
  platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html [ Failure ]
  platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html [ Failure ]
  platform/mac-wk2/tiled-drawing/fixed/four-bars.html [ Failure ]
  platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html [ Failure ]
  platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html [ Failure ]
  platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html [ Failure ]

[Simon Fraser (smfr)]

Looking

[Simon Fraser (smfr)]

(In reply to comment #4)
> This broke a number of tests on Mac:

Fixed in http://trac.webkit.org/changeset/166348