WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130785
REGRESSION(
r166264
): Broke some window.opener tests for WK2 Mavericks (Requested by brrian__ on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=130785
Summary
REGRESSION(r166264): Broke some window.opener tests for WK2 Mavericks (Reques...
WebKit Commit Bot
Reported
2014-03-26 11:27:59 PDT
http://trac.webkit.org/changeset/166264
broke the build: Broke some window.opener tests for WK2 Mavericks (Requested by brrian__ on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r166264
(9.50 KB, patch)
2014-03-26 11:28 PDT
,
WebKit Commit Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1
2014-03-26 11:28:27 PDT
Created
attachment 227867
[details]
ROLLOUT of
r166264
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Blaze Burg
Comment 2
2014-03-26 11:32:23 PDT
Sigh... looks like NetworkProcess needs the same modification as WKTR. Working hypothesis: NetworkProcess currently deals with identifiers and no frames, so it is probably mistakenly cancelling main resource loads (which always have the same identifier) early, thus the onload events don't fire somehow, and the tests time out.
WebKit Commit Bot
Comment 3
2014-03-26 11:32:25 PDT
Comment on
attachment 227867
[details]
ROLLOUT of
r166264
Clearing flags on attachment: 227867 Committed
r166302
: <
http://trac.webkit.org/changeset/166302
>
WebKit Commit Bot
Comment 4
2014-03-26 11:32:27 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug