Bug 130784 - Remove unnecessary conversion to TimeRanges
Summary: Remove unnecessary conversion to TimeRanges
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-26 11:20 PDT by Jeremy Jones
Modified: 2023-10-12 13:13 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-03-26 11:20:26 PDT 
> > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:79
> > +    setSeekableRanges(*timeRanges);
> 
> Could you pass the Vector<> directly instead of creating a temporary TimeRanges?

The is one of a couple solutions.
1) Create an encoder/decoder for TimeRanges to they can cross IPC boundary. Thus removing the vector.
2) Pass Vector<> directly, which will unnecessarily convert TimeRanges to a Vector<> in WK1.
Comment 1 David Kilzer (:ddkilzer) 2016-09-09 10:43:37 PDT 
<rdar://problem/28227915>
Comment 2 Ahmad Saleem 2023-10-12 13:13:07 PDT 
I am unable to find this in WebKit source (from searchfox.org):

'WebVideoFullscreenManagerProxy' -> does not exist.
'setSeekableRanges' -> using this as search term

__

Is it still applicable?