Bug 130693 – mathml/presentation/tokenElements-background-color.html is broken on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Martin Hock]

mathml/presentation/tokenElements-background-color.html is broken on Mac after 166170. See:
http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r166172%20(4298)/results.html

[Martin Hock]

Created attachment 227686 [details]
patch

[Martin Hock]

Transcript of #webkit conversation:

[10:40am] mhock: fredw: thank you! also, I noticed that 166170 seems to have broken mathml/presentation/tokenElements-background-color.html	 on several Mac bots - is it just a reference image problem?
[10:40am] fredw: mhock: no, it is a reftest. do you have the results?
[10:41am] mhock: fredw: here is one example: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r166172%20(4298)/results.html
[10:41am] fredw: mhock: ok, that's only some small pixel differences
[10:41am] fredw: I think it can be temporarily marked fail
[10:42am] mhock: fredw: ok
[10:42am] fredw: that's something that sometimes happens due to antialisiasing...
[10:43am] mhock: fredw: do you need me to mark it as fail, or can you do that?
[10:45am] fredw: mhock: please do so, if you don't mind. I'll only be back to work on these tomorrow.

[WebKit Commit Bot]

Comment on attachment 227686 [details]
patch

Clearing flags on attachment: 227686

Committed r166196: <http://trac.webkit.org/changeset/166196>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Martin Hock]

Reopening since the test was just marked as failed instead of fixing the actual problem.

[Frédéric Wang (:fredw)]

Created attachment 227738 [details]
Patch

Thanks for opening the bug. Hopefully, adding some padding will avoid the failures on Mac.

[Build Bot]

Comment on attachment 227738 [details]
Patch

Attachment 227738 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6478830290075648

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 227740 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Frédéric Wang (:fredw)]

Created attachment 227741 [details]
Patch

increase the padding again

[Build Bot]

Comment on attachment 227741 [details]
Patch

Attachment 227741 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6324853028159488

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 227743 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227741 [details]
Patch

Attachment 227741 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6477427983253504

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 227753 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227741 [details]
Patch

Attachment 227741 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4847319316955136

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 227759 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Frédéric Wang (:fredw)]

Created attachment 228248 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 228265 [details]
Patch

[Build Bot]

Comment on attachment 228265 [details]
Patch

Attachment 228265 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5079336067530752

New failing tests:
platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html
mathml/presentation/tokenElements-background-color.html
platform/mac/fast/scrolling/scroll-select-latched-mainframe.html
platform/mac/fast/scrolling/scroll-div-latched-mainframe.html

[Build Bot]

Created attachment 228268 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 228265 [details]
Patch

Attachment 228265 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4657123602464768

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 228273 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 228265 [details]
Patch

Attachment 228265 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5679325818912768

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 228281 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Frédéric Wang (:fredw)]

Created attachment 282717 [details]
Patch

[Build Bot]

Comment on attachment 282717 [details]
Patch

Attachment 282717 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1624689

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282722 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282717 [details]
Patch

Attachment 282717 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1624697

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282723 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282717 [details]
Patch

Attachment 282717 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1624696

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282724 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 282717 [details]
Patch

Attachment 282717 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1624726

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282725 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Frédéric Wang (:fredw)]

Created attachment 282761 [details]
Patch

[Build Bot]

Comment on attachment 282761 [details]
Patch

Attachment 282761 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1629048

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282762 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282761 [details]
Patch

Attachment 282761 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1629093

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282763 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282761 [details]
Patch

Attachment 282761 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1629098

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282764 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282761 [details]
Patch

Attachment 282761 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1629099

New failing tests:
mathml/presentation/tokenElements-background-color.html

[Build Bot]

Created attachment 282765 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Brent Fulgham]

Comment on attachment 282761 [details]
Patch

These changes look good. It seems like there is just a very small image difference in the results. Can you just use the 'failure case' results to rebaseline the "*-expected.png" files?

[Frédéric Wang (:fredw)]

(In reply to comment #42)
> Comment on attachment 282761 [details]
> Patch
> 
> These changes look good. It seems like there is just a very small image
> difference in the results. Can you just use the 'failure case' results to
> rebaseline the "*-expected.png" files?

This is a reftest not a pixel test, so I'm not sure it's a good idea (or possible) to do that. As said above, the problem seems to be an antialising issue, not a real MathML bug. Using the Ahem font makes the test more reliable on ElCapitan for me but apparently that does not work on all ports. I'll probably go back to this later.

[Frédéric Wang (:fredw)]

Created attachment 282854 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 282761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282761&action=review

> LayoutTests/mathml/presentation/tokenElements-background-color.html:14
> +        font: Ahem 20px;

This is invalid. I should be "font: 20px Ahem;". Let's see if we get better result with the new patch.

[Frédéric Wang (:fredw)]

Committed r202903: <http://trac.webkit.org/changeset/202903>