Bug 130673 - Text autosizing does not determine line count correctly for simple line layout
Summary: Text autosizing does not determine line count correctly for simple line layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-24 09:09 PDT by Antti Koivisto
Modified: 2014-03-24 09:31 PDT (History)
6 users (show)

See Also:

Attachments
patch (5.19 KB, patch)
2014-03-24 09:12 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
better patch (5.42 KB, patch)
2014-03-24 09:21 PDT, Antti Koivisto 		dbates: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-03-24 09:09:12 PDT 
Nope
Comment 1 Antti Koivisto 2014-03-24 09:12:26 PDT 
Created attachment 227651 [details]
patch
Comment 2 Antti Koivisto 2014-03-24 09:13:00 PDT 
<rdar://problem/15965114>
Comment 3 WebKit Commit Bot 2014-03-24 09:14:59 PDT 
Attachment 227651 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2014-03-24 09:21:15 PDT 
Created attachment 227655 [details]
better patch
Comment 5 Daniel Bates 2014-03-24 09:24:11 PDT 
Comment on attachment 227655 [details]
better patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227655&action=review

> Source/WebCore/ChangeLog:8
> +        We don't count lines correctly in simple line layout case.

I'm unclear if we have DRT for iOS working. It would be great if we could write a test for this.
Comment 6 Antti Koivisto 2014-03-24 09:31:53 PDT 
https://trac.webkit.org/r166171