Bug 130635 – Web Inspector: AXI: add other ARIA one-to-many relationships: owns, flowto, controls.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[James Craig]

Web Inspector: AXI: add other ARIA one-to-many relationships: owns, flowto, controls.
Not including labelledby or describedby b/c those will be computed values for label, etc.

[Radar WebKit Bug Importer]

<rdar://problem/16398942>

[James Craig]

Created attachment 227541 [details]
patch

[WebKit Commit Bot]

Comment on attachment 227541 [details]
patch

Rejecting attachment 227541 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[James Craig]

Must've flubbed the cq? to cq+

[Darin Adler]

Comment on attachment 227541 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227541&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1481
> +                    for (const auto& controlledElement : controlledElements)

No need to say "const auto&" here. Just "auto&" or "auto*" is better. And "Element*" is shorter than "const auto&", so you could use that too.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1498
> +                    for (const auto& flowedElement : flowedElements)

Ditto.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1528
> +                    for (const auto& ownedElement : ownedElements)

Ditto.

[James Craig]

Created attachment 227581 [details]
patch with review feedback

[WebKit Commit Bot]

Comment on attachment 227581 [details]
patch with review feedback

Clearing flags on attachment: 227581

Committed r166141: <http://trac.webkit.org/changeset/166141>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.