Bug 130531 - Add some assertions back
Summary: Add some assertions back
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 13:03 PDT by Mark Hahnenberg
Modified: 2014-03-20 17:11 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2014-03-20 13:05 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-20 13:03:42 PDT
We removed a useful set of assertions for verifying that MarkedBlocks were in the state that we expected them to be in after clearing marks in the Heap. We should add these back to catch bugs earlier.
Comment 1 Mark Hahnenberg 2014-03-20 13:05:17 PDT
Created attachment 227322 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-20 15:52:50 PDT
Comment on attachment 227322 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-03-20 17:11:22 PDT
Comment on attachment 227322 [details]
Patch

Clearing flags on attachment: 227322

Committed r166028: <http://trac.webkit.org/changeset/166028>
Comment 4 WebKit Commit Bot 2014-03-20 17:11:24 PDT
All reviewed patches have been landed.  Closing bug.