Bug 130518 - Remove remaining GTK+ unused parameter warnings from WebKit2
Summary: Remove remaining GTK+ unused parameter warnings from WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 10:01 PDT by Martin Robinson
Modified: 2014-03-20 10:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.64 KB, patch)
2014-03-20 10:03 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-03-20 10:01:03 PDT 
These warnings can hide potential problems and we didn't have them turned on before using CMake. Fixing them all at once makes sense.
Comment 1 Martin Robinson 2014-03-20 10:03:41 PDT 
Created attachment 227299 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-20 10:06:07 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Sergio Villar Senin 2014-03-20 10:10:05 PDT 
Comment on attachment 227299 [details]
Patch

Awesome cleanup
Comment 4 Martin Robinson 2014-03-20 10:21:24 PDT 
Comment on attachment 227299 [details]
Patch

Clearing flags on attachment: 227299

Committed r165968: <http://trac.webkit.org/changeset/165968>
Comment 5 Martin Robinson 2014-03-20 10:21:28 PDT 
All reviewed patches have been landed.  Closing bug.