RESOLVED FIXED130438
Small cleanup of empty string 
https://bugs.webkit.org/show_bug.cgi?id=130438
Summary Small cleanup of empty string
Gavin Barraclough
Reported 2014-03-18 18:45:59 PDT
Some prep for https://bugs.webkit.org/show_bug.cgi?id=128624.
Attachments
Fix (5.37 KB, patch)
2014-03-18 19:05 PDT, Gavin Barraclough 		andersca: review+
DetailsFormatted DiffDiff
Patch with review comments for EWS (5.72 KB, patch)
2014-03-18 19:41 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-03-18 19:05:32 PDT
Created attachment 227144 [details] Fix
Andreas Kling
Comment 2 2014-03-18 19:08:22 PDT
The PCRE workaround removal has been attempted before, see bug 123265.
Gavin Barraclough
Comment 3 2014-03-18 19:21:15 PDT
(In reply to comment #2) > The PCRE workaround removal has been attempted before, see bug 123265. Hmmm, interesting. :-( The tests mentioned in the bug pass for me, maybe I should try again. :-/
Anders Carlsson
Comment 4 2014-03-18 19:22:15 PDT
Comment on attachment 227144 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=227144&action=review > Source/WTF/wtf/text/StringImpl.h:164 > + , m_data8(reinterpret_cast<LChar*>(1)) Even though this is what the comment said, I think it's awkward. I think you should do what we do for the StringImpl(CreateEmptyUniqueTag) constructor instead: // We expect m_length to be initialized to 0 as we use it // to represent a null terminated buffer. , m_data8(reinterpret_cast<const LChar*>(&m_length)) > Source/WTF/wtf/text/StringStatics.cpp:46 > + DEPRECATED_DEFINE_STATIC_LOCAL(StringImpl, emptyString, (ConstructEmptyString)); Please change this to static NeverDestroyed<StringImpl> emptyString(ConstructEmptyString); instead.
Gavin Barraclough
Comment 5 2014-03-18 19:41:44 PDT
Created attachment 227148 [details] Patch with review comments for EWS
Gavin Barraclough
Comment 6 2014-03-19 12:02:56 PDT
Fixed in r165906
Note You need to log in before you can comment on or make changes to this bug.