Bug 130434 – [WebRTC] Moving RTCConfiguration and RTCIceServer to Modules/mediastream

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

Those classes are defined in WebRTC spec, so they should not be in platform layer.
Adding a platform implementation to be passed to handler classes.

[Thiago de Barros Lacerda]

Created attachment 227135 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 227135 [details]
Patch

Rejecting attachment 227135 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/PrivateHeaders

** BUILD FAILED **


The following build commands failed:
	CpHeader platform/mediastream/RTCConfiguration.h /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/PrivateHeaders/RTCConfiguration.h
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5509347186573312

[Eric Carlson]

Created attachment 227213 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 227213 [details]
Patch for landing

Rejecting attachment 227213 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227213, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6188378294845440

[Thiago de Barros Lacerda]

Created attachment 227306 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 227306 [details]
Patch for landing

Rejecting attachment 227306 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/PlatformWebViewMac.o mac/PlatformWebViewMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/TestController.o TestController.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

Full output: http://webkit-queues.appspot.com/results/5825589923545088

[Thiago de Barros Lacerda]

Comment on attachment 227306 [details]
Patch for landing

was cq- due to broken tree.
cq+ again. The build seems to be fixed.

[WebKit Commit Bot]

Comment on attachment 227306 [details]
Patch for landing

Clearing flags on attachment: 227306

Committed r166003: <http://trac.webkit.org/changeset/166003>