Bug 130434 - [WebRTC] Moving RTCConfiguration and RTCIceServer to Modules/mediastream
Summary: [WebRTC] Moving RTCConfiguration and RTCIceServer to Modules/mediastream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks: 124288
  Show dependency treegraph
 
Reported: 2014-03-18 17:07 PDT by Thiago de Barros Lacerda
Modified: 2014-05-19 09:08 PDT (History)
8 users (show)

See Also:


Attachments
Patch (26.56 KB, patch)
2014-03-18 17:11 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff
Patch for landing (37.51 KB, patch)
2014-03-19 14:06 PDT, Eric Carlson
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (38.12 KB, patch)
2014-03-20 11:19 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2014-03-18 17:07:17 PDT
Those classes are defined in WebRTC spec, so they should not be in platform layer.
Adding a platform implementation to be passed to handler classes.
Comment 1 Thiago de Barros Lacerda 2014-03-18 17:11:39 PDT
Created attachment 227135 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-19 12:37:01 PDT
Comment on attachment 227135 [details]
Patch

Rejecting attachment 227135 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip -resolve-src-symlinks /Volumes/Data/EWS/WebKit/Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/PrivateHeaders

** BUILD FAILED **


The following build commands failed:
	CpHeader platform/mediastream/RTCConfiguration.h /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/PrivateHeaders/RTCConfiguration.h
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5509347186573312
Comment 3 Eric Carlson 2014-03-19 14:06:50 PDT
Created attachment 227213 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2014-03-20 10:51:10 PDT
Comment on attachment 227213 [details]
Patch for landing

Rejecting attachment 227213 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227213, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6188378294845440
Comment 5 Thiago de Barros Lacerda 2014-03-20 11:19:51 PDT
Created attachment 227306 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-03-20 13:34:25 PDT
Comment on attachment 227306 [details]
Patch for landing

Rejecting attachment 227306 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/PlatformWebViewMac.o mac/PlatformWebViewMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/TestController.o TestController.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

Full output: http://webkit-queues.appspot.com/results/5825589923545088
Comment 7 Thiago de Barros Lacerda 2014-03-20 13:47:05 PDT
Comment on attachment 227306 [details]
Patch for landing

was cq- due to broken tree.
cq+ again. The build seems to be fixed.
Comment 8 WebKit Commit Bot 2014-03-20 14:19:31 PDT
Comment on attachment 227306 [details]
Patch for landing

Clearing flags on attachment: 227306

Committed r166003: <http://trac.webkit.org/changeset/166003>