Bug 130416 - Share MemoryPressureHandler::releaseMemory() between platforms.
Summary: Share MemoryPressureHandler::releaseMemory() between platforms.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 13:16 PDT by Andreas Kling
Modified: 2014-03-18 19:36 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.24 KB, patch)
2014-03-18 13:17 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (5.15 KB, patch)
2014-03-18 13:25 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (6.08 KB, patch)
2014-03-18 13:36 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-03-18 13:16:26 PDT 
Share MemoryPressureHandler::releaseMemory() between platforms.
Comment 1 Andreas Kling 2014-03-18 13:17:20 PDT 
Created attachment 227094 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-18 13:19:25 PDT 
Attachment 227094 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/MemoryPressureHandler.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/MemoryPressureHandler.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-03-18 13:25:44 PDT 
Created attachment 227097 [details]
Patch
Comment 4 Andreas Kling 2014-03-18 13:36:35 PDT 
Created attachment 227099 [details]
Patch
Comment 5 Antti Koivisto 2014-03-18 14:51:15 PDT 
Comment on attachment 227099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227099&action=review

> Source/WebCore/platform/MemoryPressureHandler.cpp:82
> +    for (auto* document : Document::allDocuments())

pointer :O
Comment 6 WebKit Commit Bot 2014-03-18 19:33:55 PDT 
Comment on attachment 227099 [details]
Patch

Clearing flags on attachment: 227099

Committed r165866: <http://trac.webkit.org/changeset/165866>
Comment 7 WebKit Commit Bot 2014-03-18 19:36:07 PDT 
All reviewed patches have been landed.  Closing bug.