Bug 130374 - Renable pagination mode in WK2 MiniBrowser
Summary: Renable pagination mode in WK2 MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 17:46 PDT by Simon Fraser (smfr)
Modified: 2014-03-18 10:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.35 KB, patch)
2014-03-17 17:47 PDT, Simon Fraser (smfr) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-03-17 17:46:46 PDT 
Renable pagination mode in WK2 MiniBrowser
Comment 1 Simon Fraser (smfr) 2014-03-17 17:47:38 PDT 
Created attachment 226988 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-17 17:48:56 PDT 
Attachment 226988 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:97:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:100:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:102:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:103:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-03-17 20:09:30 PDT 
Comment on attachment 226988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226988&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:40
> +    WKPaginationModeUnpaginated,
> +    WKPaginationModeLeftToRight,
> +    WKPaginationModeRightToLeft,
> +    WKPaginationModeTopToBottom,
> +    WKPaginationModeBottomToTop,

These should also be prefixed.
Comment 4 Simon Fraser (smfr) 2014-03-18 10:58:03 PDT 
https://trac.webkit.org/r165817