Bug 130365 - Move convertToRange() helper to cross-platform WebPage.cpp
Summary: Move convertToRange() helper to cross-platform WebPage.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 15:14 PDT by Alexey Proskuryakov
Modified: 2014-03-17 15:29 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (8.98 KB, patch)
2014-03-17 15:16 PDT, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-03-17 15:14:57 PDT 
convertToRange() is duplicated in Mac and iOS code, and it's really cross-platform.
Comment 1 Alexey Proskuryakov 2014-03-17 15:16:33 PDT 
Created attachment 226970 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-03-17 15:18:18 PDT 
Attachment 226970 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4344:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-03-17 15:29:01 PDT 
Committed <http://trac.webkit.org/r165767>.