[GTK][CMake] Build with -fno-rtti
Created attachment 226763 [details] Patch
Comment on attachment 226763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226763&action=review > Source/cmake/gtest/CMakeLists.txt:25 > +add_definitions(-DGTEST_CREATE_SHARED_LIBRARY=1 -DGTEST_HAS_RTTI=0) New line please. > Tools/TestWebKitAPI/CMakeLists.txt:89 > +add_definitions(-DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DGTEST_HAS_RTTI=0 New line please.
Comment on attachment 226763 [details] Patch Clearing flags on attachment: 226763 Committed r165709: <http://trac.webkit.org/changeset/165709>
All reviewed patches have been landed. Closing bug.
+ set(CMAKE_C_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing") Is this added line correct? Causes build failures in udis86 which explicitly asks for gcc but then gets g++ flags from CMAKE_CXX_FLAGS. cc1: error: command line option '-fvisibility-inlines-hidden' is valid for C++/ObjC++ but not for C [-Werror] cc1: error: command line option '-fpermissive' is valid for C++/ObjC++ but not for C [-Werror] cc1: all warnings being treated as errors Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/build.make:11182: recipe for target 'Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/disassembler/udis86/udis86.c.o' failed make[2]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/disassembler/udis86/udis86.c.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/OE/build/oe-core/tmp-eglibc/work/core2-64-oe-linux/webkit-efl/1_1.10.0+1.11.0-beta1-r0/build'
(In reply to comment #5) > + set(CMAKE_C_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing") > > Is this added line correct? > > Causes build failures in udis86 which explicitly asks for gcc but then gets g++ flags from CMAKE_CXX_FLAGS. Yes, that's not correct. My bad. Fixed in r172579. http://trac.webkit.org/changeset/172579