Bug 130231 - Move WebSpeech code to use std::unique_ptr
Summary: Move WebSpeech code to use std::unique_ptr
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Krzysztof Czech
Depends on:
Reported: 2014-03-14 02:48 PDT by Krzysztof Czech
Modified: 2014-03-14 09:25 PDT (History)
3 users (show)

See Also:

patch (10.97 KB, patch)
2014-03-14 02:52 PDT, Krzysztof Czech
no flags Details | Formatted Diff | Diff
patch (10.97 KB, patch)
2014-03-14 02:57 PDT, Krzysztof Czech
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2014-03-14 02:48:31 PDT
Replace uses of OwnPtr and PassOwnPtr in WebSpeech code with std::unique_ptr.
Comment 1 Krzysztof Czech 2014-03-14 02:52:04 PDT
Created attachment 226673 [details]
Comment 2 WebKit Commit Bot 2014-03-14 02:53:14 PDT
Attachment 226673 [details] did not pass style-queue:

ERROR: Source/WebCore/Modules/speech/SpeechSynthesis.cpp:118:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 8 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Krzysztof Czech 2014-03-14 02:57:36 PDT
Created attachment 226674 [details]
Comment 4 WebKit Commit Bot 2014-03-14 09:25:41 PDT
Comment on attachment 226674 [details]

Clearing flags on attachment: 226674

Committed r165624: <http://trac.webkit.org/changeset/165624>
Comment 5 WebKit Commit Bot 2014-03-14 09:25:45 PDT
All reviewed patches have been landed.  Closing bug.