WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130231
Move WebSpeech code to use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=130231
Summary
Move WebSpeech code to use std::unique_ptr
Krzysztof Czech
Reported
2014-03-14 02:48:31 PDT
Replace uses of OwnPtr and PassOwnPtr in WebSpeech code with std::unique_ptr.
Attachments
patch
(10.97 KB, patch)
2014-03-14 02:52 PDT
,
Krzysztof Czech
no flags
Details
Formatted Diff
Diff
patch
(10.97 KB, patch)
2014-03-14 02:57 PDT
,
Krzysztof Czech
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Krzysztof Czech
Comment 1
2014-03-14 02:52:04 PDT
Created
attachment 226673
[details]
patch
WebKit Commit Bot
Comment 2
2014-03-14 02:53:14 PDT
Attachment 226673
[details]
did not pass style-queue: ERROR: Source/WebCore/Modules/speech/SpeechSynthesis.cpp:118: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Krzysztof Czech
Comment 3
2014-03-14 02:57:36 PDT
Created
attachment 226674
[details]
patch
WebKit Commit Bot
Comment 4
2014-03-14 09:25:41 PDT
Comment on
attachment 226674
[details]
patch Clearing flags on attachment: 226674 Committed
r165624
: <
http://trac.webkit.org/changeset/165624
>
WebKit Commit Bot
Comment 5
2014-03-14 09:25:45 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug