Bug 130223 - Move visited link handling to VisitedLinkTableController and VisitedLinkProvider
Summary: Move visited link handling to VisitedLinkTableController and VisitedLinkProvider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-13 21:14 PDT by Anders Carlsson
Modified: 2014-03-14 08:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (48.57 KB, patch)
2014-03-13 21:28 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-03-13 21:14:04 PDT 
Move visited link handling to VisitedLinkTableController and VisitedLinkProvider
Comment 1 Anders Carlsson 2014-03-13 21:28:19 PDT 
Created attachment 226648 [details]
Patch
Comment 2 mitz 2014-03-13 21:53:44 PDT 
Comment on attachment 226648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226648&action=review

> Source/WebKit2/ChangeLog:26
> +        add the VisitedLinkProvider  object as a message receiver and send the visited link table to the process.

extra space

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:180
> +        ASSERT(currentTableMemory->size() == m_tableSize * sizeof(LinkHash));

This isn’t right

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:192
> +            if (!m_table.addLinkHash(linkHash))
> +                ASSERT_NOT_REACHED();

It’s nicer to use a local bool and ASSERT_UNUSED in such cases.

> Source/WebKit2/UIProcess/VisitedLinkProvider.messages.in:1
> +# Copyright (C) 2011 Apple Inc. All rights reserved.

2011?

> Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h:52
> +    void visitedLinkStateChanged(const Vector<WebCore::LinkHash>& linkHashes);

Don’t need to name this parameter.

> Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.messages.in:1
> +# Copyright (C) 2011 Apple Inc. All rights reserved.

2011 again?
Comment 3 Anders Carlsson 2014-03-14 08:41:38 PDT 
Committed r165619: <http://trac.webkit.org/changeset/165619>