RESOLVED FIXED 130223
Move visited link handling to VisitedLinkTableController and VisitedLinkProvider 
https://bugs.webkit.org/show_bug.cgi?id=130223
Summary Move visited link handling to VisitedLinkTableController and VisitedLinkProvider
Anders Carlsson
Reported 2014-03-13 21:14:04 PDT
Move visited link handling to VisitedLinkTableController and VisitedLinkProvider
Attachments
Patch (48.57 KB, patch)
2014-03-13 21:28 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-03-13 21:28:19 PDT
Created attachment 226648 [details] Patch
mitz
Comment 2 2014-03-13 21:53:44 PDT
Comment on attachment 226648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226648&action=review > Source/WebKit2/ChangeLog:26 > + add the VisitedLinkProvider object as a message receiver and send the visited link table to the process. extra space > Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:180 > + ASSERT(currentTableMemory->size() == m_tableSize * sizeof(LinkHash)); This isn’t right > Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:192 > + if (!m_table.addLinkHash(linkHash)) > + ASSERT_NOT_REACHED(); It’s nicer to use a local bool and ASSERT_UNUSED in such cases. > Source/WebKit2/UIProcess/VisitedLinkProvider.messages.in:1 > +# Copyright (C) 2011 Apple Inc. All rights reserved. 2011? > Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h:52 > + void visitedLinkStateChanged(const Vector<WebCore::LinkHash>& linkHashes); Don’t need to name this parameter. > Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.messages.in:1 > +# Copyright (C) 2011 Apple Inc. All rights reserved. 2011 again?
Anders Carlsson
Comment 3 2014-03-14 08:41:38 PDT
Committed r165619: <http://trac.webkit.org/changeset/165619>
Note You need to log in before you can comment on or make changes to this bug.