WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
130218
The viewport code should not depend on WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=130218
Summary
The viewport code should not depend on WebKitSystemInterface
Benjamin Poulain
Reported
2014-03-13 17:03:37 PDT
The viewport code should not depend on WebKitSystemInterface
Attachments
Patch
(17.56 KB, patch)
2014-03-13 17:07 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-03-13 17:07:18 PDT
Created
attachment 226630
[details]
Patch
Tim Horton
Comment 2
2014-03-13 17:10:36 PDT
Comment on
attachment 226630
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=226630&action=review
> Source/WebCore/page/ChromeClient.h:179 > + virtual FloatSize viewportScreenSize() const { return const_cast<ChromeClient*>(this)->windowRect().size(); }
:| const_cast!
Benjamin Poulain
Comment 3
2014-03-13 17:21:54 PDT
Comment on
attachment 226630
[details]
Patch Clearing flags on attachment: 226630 Committed
r165577
: <
http://trac.webkit.org/changeset/165577
>
Benjamin Poulain
Comment 4
2014-03-13 17:21:56 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug