Bug 130218 - The viewport code should not depend on WebKitSystemInterface
Summary: The viewport code should not depend on WebKitSystemInterface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-13 17:03 PDT by Benjamin Poulain
Modified: 2014-03-13 17:21 PDT (History)
0 users

See Also:

Attachments
Patch (17.56 KB, patch)
2014-03-13 17:07 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-03-13 17:03:37 PDT 
The viewport code should not depend on WebKitSystemInterface
Comment 1 Benjamin Poulain 2014-03-13 17:07:18 PDT 
Created attachment 226630 [details]
Patch
Comment 2 Tim Horton 2014-03-13 17:10:36 PDT 
Comment on attachment 226630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226630&action=review

> Source/WebCore/page/ChromeClient.h:179
> +    virtual FloatSize viewportScreenSize() const { return const_cast<ChromeClient*>(this)->windowRect().size(); }

:| const_cast!
Comment 3 Benjamin Poulain 2014-03-13 17:21:54 PDT 
Comment on attachment 226630 [details]
Patch

Clearing flags on attachment: 226630

Committed r165577: <http://trac.webkit.org/changeset/165577>
Comment 4 Benjamin Poulain 2014-03-13 17:21:56 PDT 
All reviewed patches have been landed.  Closing bug.