Bug 130172 - [iOS] Sync media playback with now playing
Summary: [iOS] Sync media playback with now playing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-12 19:28 PDT by Eric Carlson
Modified: 2014-03-13 11:25 PDT (History)
9 users (show)

See Also:

Attachments
Proposed patch. (17.48 KB, patch)
2014-03-12 19:52 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-03-12 19:28:23 PDT 
Pass information about the currently playing media element to MPNowPlayingInfoCenter.
Comment 1 Eric Carlson 2014-03-12 19:52:59 PDT 
Created attachment 226569 [details]
Proposed patch.
Comment 2 Jer Noble 2014-03-13 08:49:06 PDT 
Comment on attachment 226569 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=226569&action=review

r=me

> Source/WebCore/platform/audio/MediaSessionManager.cpp:157
> -
> +    

Whew, I was worried I wouldn't have a nit!  Ahem, unnecessary whitespace.

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:42
> +#import <MediaPlayer/MPRemoteCommand.h>
> +#import <MediaPlayer/MPRemoteCommandCenter.h>
> +#import <MediaPlayer/MPRemoteCommandEvent.h>

It looks like these are unused.  (For now.)

> Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:71
> +SOFT_LINK_CLASS(MediaPlayer, MPRemoteCommandCenter)

Ditto.
Comment 3 Eric Carlson 2014-03-13 11:25:30 PDT 
Committed r165552: https://trac.webkit.org/r165552