RESOLVED FIXED130087
Webkit not building on XCode 5.1 due to garbage collection no longer being supported 
https://bugs.webkit.org/show_bug.cgi?id=130087
Summary Webkit not building on XCode 5.1 due to garbage collection no longer being su...
Radu Stavila
Reported 2014-03-11 06:48:46 PDT
Webkit not building on XCode 5.1 due to garbage collection no longer being supported
Attachments
Patch (7.38 KB, patch)
2014-03-11 07:23 PDT, Radu Stavila 		mrowe: review-
DetailsFormatted DiffDiff
Patch v2 (145.25 KB, patch)
2014-03-11 15:33 PDT, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Rebased patch (9.72 KB, patch)
2014-03-11 15:41 PDT, Radu Stavila 		mrowe: review+
DetailsFormatted DiffDiff
Patch for landing (12.96 KB, patch)
2014-03-11 16:05 PDT, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radu Stavila
Comment 1 2014-03-11 07:23:05 PDT
Created attachment 226424 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-11 07:25:38 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Mark Rowe (bdash)
Comment 3 2014-03-11 09:53:15 PDT
Comment on attachment 226424 [details] Patch We can't disable garbage collection entirely since that would be an ABI-incompatible change, breaking clients of WebKit that build with GC enabled. We'll need to disable it when USE_INTERNAL_SDK is unset and leave it set to "supported" when USE_INTERNAL_SDK is YES.
Radu Stavila
Comment 4 2014-03-11 15:33:36 PDT
Created attachment 226435 [details] Patch v2
Radu Stavila
Comment 5 2014-03-11 15:41:25 PDT
Created attachment 226438 [details] Rebased patch
Mark Rowe (bdash)
Comment 6 2014-03-11 15:46:56 PDT
Comment on attachment 226438 [details] Rebased patch Looks fine. You'll probably want to remove the #include of UseInternalSDK.xcconfig from DebugRelease.xcconfig in each of the projects you've modified though, otherwise people outside of Apple will get twice the number of warnings about its absence.
Radu Stavila
Comment 7 2014-03-11 16:05:10 PDT
Created attachment 226441 [details] Patch for landing
Alexey Proskuryakov
Comment 8 2014-03-12 10:13:35 PDT
Comment on attachment 226441 [details] Patch for landing Removing and re-adding cq+ flag, hopefully commit queue will pick it up then.
Radu Stavila
Comment 9 2014-03-12 10:17:16 PDT
Comment on attachment 226441 [details] Patch for landing You forgot to re-add it :) I'm gonna land it manually if the cq bot doesn't pick it up.
Alexey Proskuryakov
Comment 10 2014-03-12 10:18:21 PDT
> You forgot to re-add it :) It was taking time, Bugzilla is slow today.
Dirk Schulze
Comment 11 2014-03-12 23:05:55 PDT
(In reply to comment #9) > (From update of attachment 226441 [details]) > You forgot to re-add it :) I'm gonna land it manually if the cq bot doesn't pick it up. Please land it manually.
Bem Jones-Bey
Comment 12 2014-03-13 11:06:30 PDT
Committed r165549: <http://trac.webkit.org/changeset/165549>
Bem Jones-Bey
Comment 13 2014-03-13 11:07:52 PDT
Comment on attachment 226441 [details] Patch for landing removing the cq+ just to be safe.
Tim Horton
Comment 14 2014-03-13 16:37:06 PDT
There weren't quite enough ".."s in the new paths in the ThirdParty/ANGLE and WebKit/mac xcconfigs, which are both one directory deeper than the others.
Bem Jones-Bey
Comment 15 2014-03-13 17:03:12 PDT
(In reply to comment #14) > There weren't quite enough ".."s in the new paths in the ThirdParty/ANGLE and WebKit/mac xcconfigs, which are both one directory deeper than the others. Did you fix that, or are you asking for a follow-up patch to fix it?
Tim Horton
Comment 16 2014-03-13 17:12:38 PDT
(In reply to comment #14) > There weren't quite enough ".."s in the new paths in the ThirdParty/ANGLE and WebKit/mac xcconfigs, which are both one directory deeper than the others. Fixed in http://trac.webkit.org/changeset/165576
Note You need to log in before you can comment on or make changes to this bug.