Bug 130047 - Add SPI to run javascript in main frame on WKWebView
Summary: Add SPI to run javascript in main frame on WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad All
: P4 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-10 15:55 PDT by Paul Hankes Drielsma
Modified: 2014-03-13 19:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2014-03-10 16:05 PDT, Paul Hankes Drielsma 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2014-03-11 09:39 PDT, Paul Hankes Drielsma 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Hankes Drielsma 2014-03-10 15:55:31 PDT 
Expose runJavascript API to WKWebView via SPI for use in Safari.
Comment 1 Paul Hankes Drielsma 2014-03-10 16:05:28 PDT 
Created attachment 226347 [details]
Patch
Comment 2 mitz 2014-03-10 16:20:55 PDT 
Comment on attachment 226347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226347&action=review

> Source/WebKit2/ChangeLog:3
> +        Add SPI to run javascript in main frame on WKWebView.

No need for this. The bug title and URL below suffice. Although this makes for a better title than the bug’s current title.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:856
> +    _page->runJavaScriptInMainFrame(scriptString, WebKit::ScriptValueCallback::create([](bool b, WebKit::WebSerializedScriptValue* sv){}));

We typically don’t name unused parameters.
Comment 3 Paul Hankes Drielsma 2014-03-11 09:39:40 PDT 
Created attachment 226433 [details]
Patch
Comment 4 WebKit Commit Bot 2014-03-13 19:02:15 PDT 
Comment on attachment 226433 [details]
Patch

Clearing flags on attachment: 226433

Committed r165591: <http://trac.webkit.org/changeset/165591>
Comment 5 WebKit Commit Bot 2014-03-13 19:02:18 PDT 
All reviewed patches have been landed.  Closing bug.