Bug 129973 - Dont check for shm_open in librt, doesnt exist on OpenBSD
Summary: Dont check for shm_open in librt, doesnt exist on OpenBSD
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-08 11:24 PST by Landry Breuil
Modified: 2014-03-08 14:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2014-03-08 11:26 PST, Landry Breuil 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Landry Breuil 2014-03-08 11:24:11 PST 
OpenBSD has shm_open directly in libc, and we dont have librt, so build fails at some point when a test binary tries to link with SHM_LIBS.
Comment 1 Landry Breuil 2014-03-08 11:26:32 PST 
Created attachment 226221 [details]
Patch
Comment 2 Andreas Kling 2014-03-08 13:33:29 PST 
I got the impression that the autotools build system might be on its way out. You might want to do the same fix in CMake land. (CC'ing mrobinson who will know.)
Comment 3 Martin Robinson 2014-03-08 13:48:57 PST 
Comment on attachment 226221 [details]
Patch

It looks like the CMake port doesn't explicitly link against librt. It may have to once it is tested on more systems, but I don't think this fix needs to be extended to CMake yet.
Comment 4 WebKit Commit Bot 2014-03-08 14:04:07 PST 
Comment on attachment 226221 [details]
Patch

Clearing flags on attachment: 226221

Committed r165337: <http://trac.webkit.org/changeset/165337>
Comment 5 WebKit Commit Bot 2014-03-08 14:04:10 PST 
All reviewed patches have been landed.  Closing bug.