WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129973
Dont check for shm_open in librt, doesnt exist on OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=129973
Summary
Dont check for shm_open in librt, doesnt exist on OpenBSD
Landry Breuil
Reported
2014-03-08 11:24:11 PST
OpenBSD has shm_open directly in libc, and we dont have librt, so build fails at some point when a test binary tries to link with SHM_LIBS.
Attachments
Patch
(1.31 KB, patch)
2014-03-08 11:26 PST
,
Landry Breuil
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Landry Breuil
Comment 1
2014-03-08 11:26:32 PST
Created
attachment 226221
[details]
Patch
Andreas Kling
Comment 2
2014-03-08 13:33:29 PST
I got the impression that the autotools build system might be on its way out. You might want to do the same fix in CMake land. (CC'ing mrobinson who will know.)
Martin Robinson
Comment 3
2014-03-08 13:48:57 PST
Comment on
attachment 226221
[details]
Patch It looks like the CMake port doesn't explicitly link against librt. It may have to once it is tested on more systems, but I don't think this fix needs to be extended to CMake yet.
WebKit Commit Bot
Comment 4
2014-03-08 14:04:07 PST
Comment on
attachment 226221
[details]
Patch Clearing flags on attachment: 226221 Committed
r165337
: <
http://trac.webkit.org/changeset/165337
>
WebKit Commit Bot
Comment 5
2014-03-08 14:04:10 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug