Bug 129970 - AX: Trailing semicolon in Tools/DumpRenderTree/AccessibilityUIElement.cpp since bug 129039
Summary: AX: Trailing semicolon in Tools/DumpRenderTree/AccessibilityUIElement.cpp sin...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 129039
  Show dependency treegraph
 
Reported: 2014-03-08 11:06 PST by Landry Breuil
Modified: 2014-03-29 15:36 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.36 KB, patch)
2014-03-08 11:11 PST, Landry Breuil
cfleizach: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Landry Breuil 2014-03-08 11:06:55 PST
-    if (argumentCount == 1);
+    if (argumentCount == 1)
         indexNumber = JSValueToNumber(context, arguments[0], exception);
Comment 1 Landry Breuil 2014-03-08 11:11:41 PST
Created attachment 226218 [details]
Patch
Comment 2 Landry Breuil 2014-03-08 11:14:47 PST
The gcc warning was:

../../../src/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:1213:28: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     if (argumentCount == 1);
Comment 3 Landry Breuil 2014-03-27 06:34:03 PDT
Can someone land this please? Pretty trivial..
Comment 4 Radar WebKit Bug Importer 2014-03-27 06:34:13 PDT
<rdar://problem/16443615>
Comment 5 Alexey Proskuryakov 2014-03-27 09:36:57 PDT
Comment on attachment 226218 [details]
Patch

> Can someone land this please? Pretty trivial..

Another way to ask would be to mark the patch with cq? flag.
Comment 6 WebKit Commit Bot 2014-03-27 09:38:16 PDT
Comment on attachment 226218 [details]
Patch

Rejecting attachment 226218 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226218, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5457624170496000
Comment 7 Landry Breuil 2014-03-27 14:58:43 PDT
That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome.
Comment 8 chris fleizach 2014-03-28 09:09:14 PDT
(In reply to comment #7)
> That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome.

You don't have to manually add the reviewed by line. If you leave in the Reviewed By OOPS line, the CQ will auto fix that for you. However if you delete that line, you'll get failures like this
Comment 9 Landry Breuil 2014-03-29 15:36:17 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome.
> 
> You don't have to manually add the reviewed by line. If you leave in the Reviewed By OOPS line, the CQ will auto fix that for you. However if you delete that line, you'll get failures like this

Hah, thanks for pointing that out, wasnt obvious. i'll try to keep it in mind for next patches.