- if (argumentCount == 1); + if (argumentCount == 1) indexNumber = JSValueToNumber(context, arguments[0], exception);
Created attachment 226218 [details] Patch
The gcc warning was: ../../../src/WebKit/Tools/DumpRenderTree/AccessibilityUIElement.cpp:1213:28: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] if (argumentCount == 1);
Can someone land this please? Pretty trivial..
<rdar://problem/16443615>
Comment on attachment 226218 [details] Patch > Can someone land this please? Pretty trivial.. Another way to ask would be to mark the patch with cq? flag.
Comment on attachment 226218 [details] Patch Rejecting attachment 226218 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 226218, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5457624170496000
That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome.
(In reply to comment #7) > That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome. You don't have to manually add the reviewed by line. If you leave in the Reviewed By OOPS line, the CQ will auto fix that for you. However if you delete that line, you'll get failures like this
(In reply to comment #8) > (In reply to comment #7) > > That's the main problem for feeding back patches to webkit, one has to upload it first, get it reviewed, manually add the reviewed by line, reupload it, and then get someone to mark it cq+ to get it commited by the commit bot. The tools are not smart enough to do this by themselves.... :( Way too cumbersome. > > You don't have to manually add the reviewed by line. If you leave in the Reviewed By OOPS line, the CQ will auto fix that for you. However if you delete that line, you'll get failures like this Hah, thanks for pointing that out, wasnt obvious. i'll try to keep it in mind for next patches.
Seems to be done already: https://github.com/WebKit/WebKit/blob/335a5587c31289a3a8043e4c460f7488c59e947b/Tools/DumpRenderTree/AccessibilityUIElement.cpp#L138 Marking this as "RESOLVED CONFIGURATION CHANGED", Thanks!