Bug 129865 - FLT should call fmod directly on platforms where LLVM cannot relocate the libcall
Summary: FLT should call fmod directly on platforms where LLVM cannot relocate the lib...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 22:59 PST by Andrew Trick
Modified: 2014-03-07 12:13 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2014-03-06 23:13 PST, Andrew Trick 		no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2014-03-07 11:23 PST, Andrew Trick 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Trick 2014-03-06 22:59:19 PST 
Posting a patch shortly.
Comment 1 Andrew Trick 2014-03-06 23:13:41 PST 
Created attachment 226089 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-07 08:58:06 PST 
Comment on attachment 226089 [details]
Patch

Clearing flags on attachment: 226089

Committed r165264: <http://trac.webkit.org/changeset/165264>
Comment 3 WebKit Commit Bot 2014-03-07 08:58:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Geoffrey Garen 2014-03-07 10:43:14 PST 
Comment on attachment 226089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226089&action=review

> Source/JavaScriptCore/ftl/FTLOutput.h:132
> +        // FIXME: LLVM may soften float operations be expanding them to libcalls.

"by"
Comment 5 Andrew Trick 2014-03-07 11:23:34 PST 
Reopening to attach new patch.
Comment 6 Andrew Trick 2014-03-07 11:23:36 PST 
Created attachment 226140 [details]
Patch
Comment 7 WebKit Commit Bot 2014-03-07 12:13:42 PST 
Comment on attachment 226140 [details]
Patch

Clearing flags on attachment: 226140

Committed r165275: <http://trac.webkit.org/changeset/165275>
Comment 8 WebKit Commit Bot 2014-03-07 12:13:46 PST 
All reviewed patches have been landed.  Closing bug.